[builtins] Re-enable embedded builtins

Re-enable embedded builtins now that 67 has branched.

This reverts two CLs:

Disable embedded builtins for M67 branch point
https://chromium-review.googlesource.com/c/v8/v8/+/982053

Enable embedded builtins on two bots
https://chromium-review.googlesource.com/c/v8/v8/+/983597

And partially:

Mark embedded builtins builds as non-shipping
https://chromium-review.googlesource.com/1005515

Bug: v8:6666
Change-Id: I8e12e99bd1ec6567baf25545147337b6a0127e2a
Reviewed-on: https://chromium-review.googlesource.com/1013570
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52637}

BUILD.gn

@@ -70,8 +70,7 @@ declare_args() {
 
   # Enable embedded builtins.
   # TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
-  # TODO(jgruber,v8:6666): Re-enable after the M67 branch point.
-  v8_enable_embedded_builtins = false
+  v8_enable_embedded_builtins = v8_current_cpu != "x86" && (!is_win || is_clang)
 
   # Enable code-generation-time checking of types in the CodeStubAssembler.
   v8_enable_verify_csa = false

infra/mb/mb_config.pyl

@@ -453,8 +453,7 @@
     'release_x64_gcc_coverage': [
       'release_bot', 'x64', 'coverage', 'gcc'],
     'release_x64_internal': [
-      'release_bot', 'x64', 'v8_enable_embedded_builtins',
-      'v8_snapshot_internal'],
+      'release_bot', 'x64', 'v8_snapshot_internal'],
     'release_x64_jumbo': [
       'release_bot', 'x64', 'jumbo'],
     'release_x64_jumbo_trybot': [
@@ -488,7 +487,7 @@
       'release_bot', 'x64', 'ubsan_vptr', 'minimal_symbols'],
     'release_x64_verify_csa': [
       'release_bot', 'x64', 'dcheck_always_on',
-      'v8_enable_slow_dchecks', 'v8_enable_embedded_builtins', 'v8_verify_csa'],
+      'v8_enable_slow_dchecks', 'v8_verify_csa'],
 
     # Debug configs for x64.
     'debug_x64': [
@@ -795,10 +794,6 @@
       'gn_args': 'v8_correctness_fuzzer=true v8_multi_arch_build=true',
     },
 
-    'v8_enable_embedded_builtins': {
-      'gn_args': 'v8_enable_embedded_builtins=true',
-    },
-
     'v8_enable_slow_dchecks': {
       'gn_args': 'v8_enable_slow_dchecks=true',
     },

test/mkgrokdump/mkgrokdump.cc

@@ -28,10 +28,7 @@ static const char* kHeader =
 // Non-snapshot builds allocate objects to different places.
 // Debug builds emit debug code, affecting code object sizes.
 // Embedded builtins cause objects to be allocated in different locations.
-// TODO(jgruber,v8:6666): Change the V8_EMBEDDED_BUILTINS condition when it
-// becomes the default.
-#if !defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && \
-    !defined(DEBUG)
+#if defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && !defined(DEBUG)
 static const char* kBuild = "shipping";
 #else
 static const char* kBuild = "non-shipping";