Commit c7ce7c7c authored by Victor Gomes's avatar Victor Gomes Committed by V8 LUCI CQ

[maglev] Remove succeed check in concurrent dispatcher

Maglev compilation can currently fail, e.g with unsupported bytecodes.

Bug: v8:7700
Change-Id: I837d69a5f9c27d4dc6fa9d03369f045fb5175d61
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3541921Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79609}
parent fa374fc9
......@@ -185,8 +185,9 @@ void MaglevConcurrentDispatcher::FinalizeFinishedJobs() {
std::unique_ptr<MaglevCompilationJob> job;
outgoing_queue_.Dequeue(&job);
CompilationJob::Status status = job->FinalizeJob(isolate_);
// TODO(v8:7700): Use the result.
CHECK_EQ(status, CompilationJob::SUCCEEDED);
// TODO(v8:7700): Use the result and check if job succeed
// when all the bytecodes are implemented.
USE(status);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment