Commit c7696479 authored by bmeurer@chromium.org's avatar bmeurer@chromium.org

Get rid of duplicated CPU::DebugBreak() method.

We already have OS::DebugBreak(), which does the right thing.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/22893050

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16293 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent de7352db
......@@ -106,15 +106,6 @@ void CPU::FlushICache(void* start, size_t size) {
#endif
}
void CPU::DebugBreak() {
#if !defined (__arm__)
UNIMPLEMENTED(); // when building ARM emulator target
#else
asm volatile("bkpt 0");
#endif
}
} } // namespace v8::internal
#endif // V8_TARGET_ARCH_ARM
......@@ -59,9 +59,6 @@ class CPU : public AllStatic {
// Flush instruction cache.
static void FlushICache(void* start, size_t size);
// Try to activate a system level debugger.
static void DebugBreak();
};
} } // namespace v8::internal
......
......@@ -72,20 +72,6 @@ void CPU::FlushICache(void* start, size_t size) {
#endif
}
void CPU::DebugBreak() {
#ifdef _MSC_VER
// To avoid Visual Studio runtime support the following code can be used
// instead
// __asm { int 3 }
__debugbreak();
#elif defined(__native_client__)
asm("hlt");
#else
asm("int $3");
#endif
}
} } // namespace v8::internal
#endif // V8_TARGET_ARCH_IA32
......@@ -87,14 +87,6 @@ void CPU::FlushICache(void* start, size_t size) {
#endif // USE_SIMULATOR.
}
void CPU::DebugBreak() {
#ifdef __mips
asm volatile("break");
#endif // #ifdef __mips
}
} } // namespace v8::internal
#endif // V8_TARGET_ARCH_MIPS
......@@ -12972,7 +12972,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_DebugSetScriptSource) {
RUNTIME_FUNCTION(MaybeObject*, Runtime_SystemBreak) {
SealHandleScope shs(isolate);
ASSERT(args.length() == 0);
CPU::DebugBreak();
OS::DebugBreak();
return isolate->heap()->undefined_value();
}
......
......@@ -72,18 +72,6 @@ void CPU::FlushICache(void* start, size_t size) {
#endif
}
void CPU::DebugBreak() {
#ifdef _MSC_VER
// To avoid Visual Studio runtime support the following code can be used
// instead
// __asm { int 3 }
__debugbreak();
#else
asm("int $3");
#endif
}
} } // namespace v8::internal
#endif // V8_TARGET_ARCH_X64
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment