Commit c728dad8 authored by bradnelson's avatar bradnelson Committed by Commit bot

Enable embenchen/copy for wasm.

This got fixed by this change:
    https://crrev.com/32a2ab0c724673961aa145ab63c79a29e6d28fa8

Adding a smaller mjsunit test capturing the issue (was with idiv register allocation).

BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=593283
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
TEST=asm-wasm-copy

Review URL: https://codereview.chromium.org/1820163002

Cr-Commit-Position: refs/heads/master@{#35041}
parent 4606211d
......@@ -271,12 +271,12 @@
'wasm/asm-wasm': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
# TODO(branelson): Figure out why ignition + asm-wasm-stdlib fails.
'wasm/asm-wasm-stdlib': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el] or ignition == True', SKIP]],
'wasm/asm-wasm-copy': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
# TODO(branelson): Figure out why ignition + asm->wasm fails embenchen.
'wasm/embenchen/*': [PASS, ['ignition == True', SKIP]],
# TODO(bradnelson) Fix and re-enable.
'wasm/embenchen/copy': [FAIL], # wrong answer
'wasm/embenchen/box2d': [SKIP], # hang
'wasm/embenchen/lua_binarytrees': [SKIP], # fails decode
'wasm/embenchen/zlib': [SKIP], # fails gc-stress
......
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --expose-wasm
(function TestCopyBug() {
// This was tickling a register allocation issue with
// idiv in embenchen/copy.
function asmModule(){
'use asm';
function func() {
var ret = 0;
var x = 1, y = 0, z = 0;
var a = 0, b = 0, c = 0, d = 0, e = 0, f = 0, g = 0;
do {
y = (x + 0) | 0;
z = (y | 0) % 2 | 0;
ret = (y + z + a + b + c + d + e + f + g) | 0;
} while(0);
return ret | 0;
}
return { func: func };
}
var wasm = Wasm.instantiateModuleFromAsm(asmModule.toString());
assertEquals(asmModule().func(), wasm.func());
})();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment