Commit c4939788 authored by Sami Kyostila's avatar Sami Kyostila Committed by V8 LUCI CQ

tracing: Disable system instrumentation tracing when using Perfetto

Disable the system instrumentation tracing feature when Perfetto is
used as a tracing mechanism. This is because with Perfetto, trace events
no longer flow through the legacy TRACE_EVENT macro mechanism and thus
can't be intercepted by v8::platform::tracing::Recorder.

Perfetto has an interceptor API[1] for this purpose, but the existing
Recorders first need to be ported to it.

[1] https://perfetto.dev/docs/instrumentation/interceptors

Change-Id: I3d10b3470ae45a4c8aedd8e128369508a462cd27
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3118546
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76491}
parent 3489bdf8
......@@ -41,7 +41,7 @@ declare_args() {
v8_enable_future = false
# Sets -DSYSTEM_INSTRUMENTATION. Enables OS-dependent event tracing
v8_enable_system_instrumentation = is_win || is_mac
v8_enable_system_instrumentation = (is_win || is_mac) && !v8_use_perfetto
# Sets the GUID for the ETW provider
v8_etw_guid = ""
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment