Removed useless getter/setter.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/64013002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17541 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 6e0ccacc
...@@ -126,21 +126,21 @@ void RelocInfo::set_target_address(Address target, WriteBarrierMode mode) { ...@@ -126,21 +126,21 @@ void RelocInfo::set_target_address(Address target, WriteBarrierMode mode) {
Object* RelocInfo::target_object() { Object* RelocInfo::target_object() {
ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
return reinterpret_cast<Object*>(Assembler::target_pointer_at(pc_)); return reinterpret_cast<Object*>(Assembler::target_address_at(pc_));
} }
Handle<Object> RelocInfo::target_object_handle(Assembler* origin) { Handle<Object> RelocInfo::target_object_handle(Assembler* origin) {
ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
return Handle<Object>(reinterpret_cast<Object**>( return Handle<Object>(reinterpret_cast<Object**>(
Assembler::target_pointer_at(pc_))); Assembler::target_address_at(pc_)));
} }
void RelocInfo::set_target_object(Object* target, WriteBarrierMode mode) { void RelocInfo::set_target_object(Object* target, WriteBarrierMode mode) {
ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); ASSERT(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
ASSERT(!target->IsConsString()); ASSERT(!target->IsConsString());
Assembler::set_target_pointer_at(pc_, reinterpret_cast<Address>(target)); Assembler::set_target_address_at(pc_, reinterpret_cast<Address>(target));
if (mode == UPDATE_WRITE_BARRIER && if (mode == UPDATE_WRITE_BARRIER &&
host() != NULL && host() != NULL &&
target->IsHeapObject()) { target->IsHeapObject()) {
...@@ -263,7 +263,7 @@ void RelocInfo::WipeOut() { ...@@ -263,7 +263,7 @@ void RelocInfo::WipeOut() {
IsCodeTarget(rmode_) || IsCodeTarget(rmode_) ||
IsRuntimeEntry(rmode_) || IsRuntimeEntry(rmode_) ||
IsExternalReference(rmode_)); IsExternalReference(rmode_));
Assembler::set_target_pointer_at(pc_, NULL); Assembler::set_target_address_at(pc_, NULL);
} }
...@@ -397,7 +397,7 @@ Address Assembler::target_pointer_address_at(Address pc) { ...@@ -397,7 +397,7 @@ Address Assembler::target_pointer_address_at(Address pc) {
} }
Address Assembler::target_pointer_at(Address pc) { Address Assembler::target_address_at(Address pc) {
if (IsMovW(Memory::int32_at(pc))) { if (IsMovW(Memory::int32_at(pc))) {
ASSERT(IsMovT(Memory::int32_at(pc + kInstrSize))); ASSERT(IsMovT(Memory::int32_at(pc + kInstrSize)));
Instruction* instr = Instruction::At(pc); Instruction* instr = Instruction::At(pc);
...@@ -464,7 +464,7 @@ static Instr EncodeMovwImmediate(uint32_t immediate) { ...@@ -464,7 +464,7 @@ static Instr EncodeMovwImmediate(uint32_t immediate) {
} }
void Assembler::set_target_pointer_at(Address pc, Address target) { void Assembler::set_target_address_at(Address pc, Address target) {
if (IsMovW(Memory::int32_at(pc))) { if (IsMovW(Memory::int32_at(pc))) {
ASSERT(IsMovT(Memory::int32_at(pc + kInstrSize))); ASSERT(IsMovT(Memory::int32_at(pc + kInstrSize)));
uint32_t* instr_ptr = reinterpret_cast<uint32_t*>(pc); uint32_t* instr_ptr = reinterpret_cast<uint32_t*>(pc);
...@@ -495,16 +495,6 @@ void Assembler::set_target_pointer_at(Address pc, Address target) { ...@@ -495,16 +495,6 @@ void Assembler::set_target_pointer_at(Address pc, Address target) {
} }
Address Assembler::target_address_at(Address pc) {
return target_pointer_at(pc);
}
void Assembler::set_target_address_at(Address pc, Address target) {
set_target_pointer_at(pc, target);
}
} } // namespace v8::internal } } // namespace v8::internal
#endif // V8_ARM_ASSEMBLER_ARM_INL_H_ #endif // V8_ARM_ASSEMBLER_ARM_INL_H_
...@@ -785,10 +785,6 @@ class Assembler : public AssemblerBase { ...@@ -785,10 +785,6 @@ class Assembler : public AssemblerBase {
// the branch/call instruction at pc, or the object in a mov. // the branch/call instruction at pc, or the object in a mov.
INLINE(static Address target_pointer_address_at(Address pc)); INLINE(static Address target_pointer_address_at(Address pc));
// Read/Modify the pointer in the branch/call/move instruction at pc.
INLINE(static Address target_pointer_at(Address pc));
INLINE(static void set_target_pointer_at(Address pc, Address target));
// Read/Modify the code target address in the branch/call instruction at pc. // Read/Modify the code target address in the branch/call instruction at pc.
INLINE(static Address target_address_at(Address pc)); INLINE(static Address target_address_at(Address pc));
INLINE(static void set_target_address_at(Address pc, Address target)); INLINE(static void set_target_address_at(Address pc, Address target));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment