Commit c42a6418 authored by georgia.kouveli's avatar georgia.kouveli Committed by Commit Bot

Print missing builtin names when using a snapshot.

BUG=

Review-Url: https://codereview.chromium.org/2970443003
Cr-Commit-Position: refs/heads/master@{#46515}
parent b0f1b0e4
......@@ -14574,13 +14574,15 @@ void Code::Disassemble(const char* name, std::ostream& os) { // NOLINT
}
if ((name != nullptr) && (name[0] != '\0')) {
os << "name = " << name << "\n";
} else if (kind() == BUILTIN) {
name = GetIsolate()->builtins()->Lookup(instruction_start());
} else if (kind() == BYTECODE_HANDLER) {
name = GetIsolate()->interpreter()->LookupNameOfBytecodeHandler(this);
if (name != nullptr) {
os << "name = " << name << "\n";
}
} else if (kind() == BYTECODE_HANDLER) {
name = GetIsolate()->interpreter()->LookupNameOfBytecodeHandler(this);
} else {
// There are some handlers and ICs that we can also find names for with
// Builtins::Lookup.
name = GetIsolate()->builtins()->Lookup(instruction_start());
if (name != nullptr) {
os << "name = " << name << "\n";
}
......
......@@ -116,15 +116,17 @@ void Deserializer::Deserialize(Isolate* isolate) {
isolate_->heap()->undefined_value());
}
// If needed, print the dissassembly of deserialized code objects.
PrintDisassembledCodeObjects();
// Issue code events for newly deserialized code objects.
LOG_CODE_EVENT(isolate_, LogCodeObjects());
LOG_CODE_EVENT(isolate_, LogBytecodeHandlers());
LOG_CODE_EVENT(isolate_, LogCompiledFunctions());
isolate_->builtins()->MarkInitialized();
// If needed, print the dissassembly of deserialized code objects.
// Needs to be called after the builtins are marked as initialized, in order
// to display the builtin names.
PrintDisassembledCodeObjects();
}
MaybeHandle<Object> Deserializer::DeserializePartial(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment