Commit c41c4358 authored by yangguo@chromium.org's avatar yangguo@chromium.org

Remove unnecessary virtual methods in the serializer.

R=marja@chromium.org

Review URL: https://codereview.chromium.org/339103005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 46d36e81
...@@ -456,7 +456,6 @@ class Serializer : public SerializerDeserializer { ...@@ -456,7 +456,6 @@ class Serializer : public SerializerDeserializer {
static const int kInvalidRootIndex = -1; static const int kInvalidRootIndex = -1;
int RootIndex(HeapObject* heap_object, HowToCode from); int RootIndex(HeapObject* heap_object, HowToCode from);
virtual bool ShouldBeInThePartialSnapshotCache(HeapObject* o) = 0;
intptr_t root_index_wave_front() { return root_index_wave_front_; } intptr_t root_index_wave_front() { return root_index_wave_front_; }
void set_root_index_wave_front(intptr_t value) { void set_root_index_wave_front(intptr_t value) {
ASSERT(value >= root_index_wave_front_); ASSERT(value >= root_index_wave_front_);
...@@ -572,15 +571,15 @@ class PartialSerializer : public Serializer { ...@@ -572,15 +571,15 @@ class PartialSerializer : public Serializer {
} }
// Serialize the objects reachable from a single object pointer. // Serialize the objects reachable from a single object pointer.
virtual void Serialize(Object** o); void Serialize(Object** o);
virtual void SerializeObject(Object* o, virtual void SerializeObject(Object* o,
HowToCode how_to_code, HowToCode how_to_code,
WhereToPoint where_to_point, WhereToPoint where_to_point,
int skip); int skip);
protected: private:
virtual int PartialSnapshotCacheIndex(HeapObject* o); int PartialSnapshotCacheIndex(HeapObject* o);
virtual bool ShouldBeInThePartialSnapshotCache(HeapObject* o) { bool ShouldBeInThePartialSnapshotCache(HeapObject* o) {
// Scripts should be referred only through shared function infos. We can't // Scripts should be referred only through shared function infos. We can't
// allow them to be part of the partial snapshot because they contain a // allow them to be part of the partial snapshot because they contain a
// unique ID, and deserializing several partial snapshots containing script // unique ID, and deserializing several partial snapshots containing script
...@@ -593,7 +592,7 @@ class PartialSerializer : public Serializer { ...@@ -593,7 +592,7 @@ class PartialSerializer : public Serializer {
startup_serializer_->isolate()->heap()->fixed_cow_array_map(); startup_serializer_->isolate()->heap()->fixed_cow_array_map();
} }
private:
Serializer* startup_serializer_; Serializer* startup_serializer_;
DISALLOW_COPY_AND_ASSIGN(PartialSerializer); DISALLOW_COPY_AND_ASSIGN(PartialSerializer);
}; };
...@@ -625,11 +624,6 @@ class StartupSerializer : public Serializer { ...@@ -625,11 +624,6 @@ class StartupSerializer : public Serializer {
SerializeWeakReferences(); SerializeWeakReferences();
Pad(); Pad();
} }
private:
virtual bool ShouldBeInThePartialSnapshotCache(HeapObject* o) {
return false;
}
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment