Commit c3904850 authored by erik.corry@gmail.com's avatar erik.corry@gmail.com

Fix place where linter complains about lonely {

Fix place where ARM compiler loses track of whether variables were initialized.
Review URL: http://codereview.chromium.org/9244

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@678 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 6951059c
...@@ -185,31 +185,22 @@ bool Object::IsSlicedString() { ...@@ -185,31 +185,22 @@ bool Object::IsSlicedString() {
StringShape::StringShape(String* str) StringShape::StringShape(String* str)
: type_(str->map()->instance_type()) : type_(str->map()->instance_type()) {
#ifdef DEBUG set_valid();
, valid_(true)
#endif // def DEBUG
{
ASSERT((type_ & kIsNotStringMask) == kStringTag); ASSERT((type_ & kIsNotStringMask) == kStringTag);
} }
StringShape::StringShape(Map* map) StringShape::StringShape(Map* map)
: type_(map->instance_type()) : type_(map->instance_type()) {
#ifdef DEBUG set_valid();
, valid_(true)
#endif // def DEBUG
{
ASSERT((type_ & kIsNotStringMask) == kStringTag); ASSERT((type_ & kIsNotStringMask) == kStringTag);
} }
StringShape::StringShape(InstanceType t) StringShape::StringShape(InstanceType t)
: type_(static_cast<uint32_t>(t)) : type_(static_cast<uint32_t>(t)) {
#ifdef DEBUG set_valid();
, valid_(true)
#endif // def DEBUG
{
ASSERT((type_ & kIsNotStringMask) == kStringTag); ASSERT((type_ & kIsNotStringMask) == kStringTag);
} }
......
...@@ -3060,7 +3060,10 @@ class StringShape BASE_EMBEDDED { ...@@ -3060,7 +3060,10 @@ class StringShape BASE_EMBEDDED {
private: private:
uint32_t type_; uint32_t type_;
#ifdef DEBUG #ifdef DEBUG
inline void set_valid() { valid_ = true; }
bool valid_; bool valid_;
#else
inline void set_valid() { }
#endif #endif
}; };
......
...@@ -2258,7 +2258,8 @@ static inline int Unescape(String* source, ...@@ -2258,7 +2258,8 @@ static inline int Unescape(String* source,
int length, int length,
int* step) { int* step) {
uint16_t character = source->Get(shape, i); uint16_t character = source->Get(shape, i);
int32_t hi, lo; int32_t hi = 0;
int32_t lo = 0;
if (character == '%' && if (character == '%' &&
i <= length - 6 && i <= length - 6 &&
source->Get(shape, i + 1) == 'u' && source->Get(shape, i + 1) == 'u' &&
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment