Commit c37e09d7 authored by hpayer's avatar hpayer Committed by Commit bot

Keep AllocationSpace and ObjectSpace enums in sync.

BUG=

Review URL: https://codereview.chromium.org/806693011

Cr-Commit-Position: refs/heads/master@{#25917}
parent 65e69497
...@@ -4401,18 +4401,19 @@ typedef void* (*CreateHistogramCallback)(const char* name, ...@@ -4401,18 +4401,19 @@ typedef void* (*CreateHistogramCallback)(const char* name,
typedef void (*AddHistogramSampleCallback)(void* histogram, int sample); typedef void (*AddHistogramSampleCallback)(void* histogram, int sample);
// --- Memory Allocation Callback --- // --- Memory Allocation Callback ---
enum ObjectSpace { enum ObjectSpace {
kObjectSpaceNewSpace = 1 << 0, kObjectSpaceNewSpace = 1 << 0,
kObjectSpaceOldPointerSpace = 1 << 1, kObjectSpaceOldPointerSpace = 1 << 1,
kObjectSpaceOldDataSpace = 1 << 2, kObjectSpaceOldDataSpace = 1 << 2,
kObjectSpaceCodeSpace = 1 << 3, kObjectSpaceCodeSpace = 1 << 3,
kObjectSpaceMapSpace = 1 << 4, kObjectSpaceMapSpace = 1 << 4,
kObjectSpaceLoSpace = 1 << 5, kObjectSpaceCellSpace = 1 << 5,
kObjectSpacePropertyCellSpace = 1 << 6,
kObjectSpaceAll = kObjectSpaceNewSpace | kObjectSpaceOldPointerSpace | kObjectSpaceLoSpace = 1 << 7,
kObjectSpaceOldDataSpace | kObjectSpaceCodeSpace | kObjectSpaceMapSpace | kObjectSpaceAll = kObjectSpaceNewSpace | kObjectSpaceOldPointerSpace |
kObjectSpaceLoSpace kObjectSpaceOldDataSpace | kObjectSpaceCodeSpace |
}; kObjectSpaceMapSpace | kObjectSpaceLoSpace
};
enum AllocationAction { enum AllocationAction {
kAllocationActionAllocate = 1 << 0, kAllocationActionAllocate = 1 << 0,
......
...@@ -362,6 +362,7 @@ typedef bool (*WeakSlotCallbackWithHeap)(Heap* heap, Object** pointer); ...@@ -362,6 +362,7 @@ typedef bool (*WeakSlotCallbackWithHeap)(Heap* heap, Object** pointer);
// NOTE: SpaceIterator depends on AllocationSpace enumeration values being // NOTE: SpaceIterator depends on AllocationSpace enumeration values being
// consecutive. // consecutive.
// Keep this enum in sync with the ObjectSpace enum in v8.h
enum AllocationSpace { enum AllocationSpace {
NEW_SPACE, // Semispaces collected with copying collector. NEW_SPACE, // Semispaces collected with copying collector.
OLD_POINTER_SPACE, // May contain pointers to new space. OLD_POINTER_SPACE, // May contain pointers to new space.
......
...@@ -922,6 +922,24 @@ void MemoryChunk::IncrementLiveBytesFromMutator(Address address, int by) { ...@@ -922,6 +922,24 @@ void MemoryChunk::IncrementLiveBytesFromMutator(Address address, int by) {
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// PagedSpace implementation // PagedSpace implementation
STATIC_ASSERT(static_cast<ObjectSpace>(1 << AllocationSpace::NEW_SPACE) ==
ObjectSpace::kObjectSpaceNewSpace);
STATIC_ASSERT(static_cast<ObjectSpace>(1
<< AllocationSpace::OLD_POINTER_SPACE) ==
ObjectSpace::kObjectSpaceOldPointerSpace);
STATIC_ASSERT(static_cast<ObjectSpace>(1 << AllocationSpace::OLD_DATA_SPACE) ==
ObjectSpace::kObjectSpaceOldDataSpace);
STATIC_ASSERT(static_cast<ObjectSpace>(1 << AllocationSpace::CODE_SPACE) ==
ObjectSpace::kObjectSpaceCodeSpace);
STATIC_ASSERT(static_cast<ObjectSpace>(1 << AllocationSpace::CELL_SPACE) ==
ObjectSpace::kObjectSpaceCellSpace);
STATIC_ASSERT(
static_cast<ObjectSpace>(1 << AllocationSpace::PROPERTY_CELL_SPACE) ==
ObjectSpace::kObjectSpacePropertyCellSpace);
STATIC_ASSERT(static_cast<ObjectSpace>(1 << AllocationSpace::MAP_SPACE) ==
ObjectSpace::kObjectSpaceMapSpace);
PagedSpace::PagedSpace(Heap* heap, intptr_t max_capacity, AllocationSpace space, PagedSpace::PagedSpace(Heap* heap, intptr_t max_capacity, AllocationSpace space,
Executability executable) Executability executable)
: Space(heap, space, executable), : Space(heap, space, executable),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment