Commit c360a250 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

Revert "[sandbox] Sandboxify Foreign external pointer"

This reverts commit 543b54da.

Reason for revert: Causes crashes on Android due to TBI: https://crbug.com/chromium/1344581

Original change's description:
> [sandbox] Sandboxify Foreign external pointer
>
> Bug: v8:10391
> Change-Id: I4c5c209454db316fe86f379f6b2e6dfc7ba7754e
> Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757340
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Commit-Queue: Samuel Groß <saelo@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#81703}

Bug: v8:10391
Change-Id: I88899def209c592cd353dd4ed81003f1bbb7a760
Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764440
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81731}
parent 5ada213c
...@@ -310,7 +310,7 @@ constexpr uint64_t kExternalPointerTagShift = 48; ...@@ -310,7 +310,7 @@ constexpr uint64_t kExternalPointerTagShift = 48;
// These tags must have 8 zeros and 8 ones, see comment above. // These tags must have 8 zeros and 8 ones, see comment above.
// New entries should be added with state "sandboxed". // New entries should be added with state "sandboxed".
#define EXTERNAL_POINTER_TAGS(V) \ #define EXTERNAL_POINTER_TAGS(V) \
V(kForeignForeignAddressTag, sandboxed, 0b1000000001111111) \ V(kForeignForeignAddressTag, unsandboxed, 0b1000000001111111) \
V(kNativeContextMicrotaskQueueTag, unsandboxed, 0b1000000010111111) \ V(kNativeContextMicrotaskQueueTag, unsandboxed, 0b1000000010111111) \
V(kEmbedderDataSlotPayloadTag, unsandboxed, 0b1000000011011111) \ V(kEmbedderDataSlotPayloadTag, unsandboxed, 0b1000000011011111) \
V(kCodeEntryPointTag, unsandboxed, 0b1000000011110111) \ V(kCodeEntryPointTag, unsandboxed, 0b1000000011110111) \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment