Commit c357f447 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by V8 LUCI CQ

Revert "Reland "[debugger] Try to trigger pause-on-oom flakes with an extra printf""

This reverts commit a4a152ec.

Reason for revert: We haven't seen the flakes in a while, we can re-enable functionality

Original change's description:
> Reland "[debugger] Try to trigger pause-on-oom flakes with an extra printf"
>
> This is a reland of 8f7e9158
>
> Original change's description:
> > [debugger] Try to trigger pause-on-oom flakes with an extra printf
> >
> > We have an issue that we can't repro locally. Enable back the
> > pause-on-oom tests with an extra printf with DEBUG. We will be able to
> > better assess the failures when they appear on the bot.
> >
> > Bug: v8:10876
> > Change-Id: I066539c4b5865ecb6f2e589e9543e8c9ebd4830b
> > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474782
> > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#70558}
>
> Bug: v8:10876
> Change-Id: Ice31c9455830da320ab057293c341f69e1f0c510
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484799
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70643}

Bug: v8:10876
Change-Id: I901d31e1e92bfef0b2917ea611354618e5cda585
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071404Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76302}
parent 1a3c5144
...@@ -535,10 +535,6 @@ size_t HeapLimitForDebugging(size_t initial_heap_limit) { ...@@ -535,10 +535,6 @@ size_t HeapLimitForDebugging(size_t initial_heap_limit) {
size_t V8Debugger::nearHeapLimitCallback(void* data, size_t current_heap_limit, size_t V8Debugger::nearHeapLimitCallback(void* data, size_t current_heap_limit,
size_t initial_heap_limit) { size_t initial_heap_limit) {
V8Debugger* thisPtr = static_cast<V8Debugger*>(data); V8Debugger* thisPtr = static_cast<V8Debugger*>(data);
// TODO(solanes, v8:10876): Remove when bug is solved.
#if DEBUG
printf("nearHeapLimitCallback\n");
#endif
thisPtr->m_originalHeapLimit = current_heap_limit; thisPtr->m_originalHeapLimit = current_heap_limit;
thisPtr->m_scheduledOOMBreak = true; thisPtr->m_scheduledOOMBreak = true;
v8::Local<v8::Context> context = v8::Local<v8::Context> context =
......
Check pause on OOM Check pause on OOM
nearHeapLimitCallback
reason: OOM reason: OOM
Check pause on OOM Check pause on OOM
nearHeapLimitCallback
reason: OOM reason: OOM
Check pause on OOM Check pause on OOM
nearHeapLimitCallback
reason: OOM reason: OOM
...@@ -26,12 +26,11 @@ ...@@ -26,12 +26,11 @@
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
['mode != debug or dcheck_always_on', { ['arch == x64 and mode == debug', {
# Investigating flaky tests: https://crbug.com/v8/10876. Enable only on pure debug. # Flaky tests: https://crbug.com/v8/10876
'debugger/pause-on-oom': [SKIP], 'debugger/pause-on-oom-extrawide': [PASS, FAIL],
'debugger/pause-on-oom-wide': [SKIP], 'debugger/pause-on-oom-wide': [PASS, FAIL],
'debugger/pause-on-oom-extrawide': [SKIP], }], # 'arch == x64 and mode == debug'
}], # 'mode != debug or dcheck_always_on'
############################################################################## ##############################################################################
['system == android', { ['system == android', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment