Commit c3068d13 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

Require pointer_compression_shared_cage for virtual_memory_cage

The shared pointer compression cage is a requirement for the V8 virtual
memory cage, and there are some configurations that don't enable the
former but enable the latter, which thus break.

Bug: chromium:1218005
Change-Id: I734598a952ccafd57e4ed63a71e76e4dc252057e
Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211996Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77305}
parent 5b4b305a
......@@ -476,8 +476,7 @@ if (build_with_chromium && v8_current_cpu == "arm64" &&
}
# Enable the virtual memory cage on 64-bit Chromium builds.
if (build_with_chromium &&
(v8_current_cpu == "arm64" || v8_current_cpu == "x64")) {
if (build_with_chromium && v8_enable_pointer_compression_shared_cage) {
# The cage is incompatible with lsan.
v8_enable_virtual_memory_cage = !is_lsan
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment