Commit c2c63232 authored by adamk's avatar adamk Committed by Commit bot

Two minor cleanups in pattern rewriter

- No need to call AsVariableProxy() on a VariableProxy
- Reduce AST visitor boilerplate using pre-existing macro
  (and re-alphabetize the list of non-patterns).

R=littledan@chromium.org

Review URL: https://codereview.chromium.org/1376633005

Cr-Commit-Position: refs/heads/master@{#31032}
parent 163419e8
...@@ -30,7 +30,7 @@ void Parser::PatternRewriter::DeclareAndInitializeVariables( ...@@ -30,7 +30,7 @@ void Parser::PatternRewriter::DeclareAndInitializeVariables(
void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) { void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) {
Expression* value = current_value_; Expression* value = current_value_;
descriptor_->scope->RemoveUnresolved(pattern->AsVariableProxy()); descriptor_->scope->RemoveUnresolved(pattern);
// Declare variable. // Declare variable.
// Note that we *always* must treat the initial value via a separate init // Note that we *always* must treat the initial value via a separate init
...@@ -361,16 +361,6 @@ void Parser::PatternRewriter::VisitAssignment(Assignment* node) { ...@@ -361,16 +361,6 @@ void Parser::PatternRewriter::VisitAssignment(Assignment* node) {
} }
void Parser::PatternRewriter::VisitSpread(Spread* node) {
UNREACHABLE();
}
void Parser::PatternRewriter::VisitEmptyParentheses(EmptyParentheses* node) {
UNREACHABLE();
}
// =============== UNREACHABLE ============================= // =============== UNREACHABLE =============================
void Parser::PatternRewriter::Visit(AstNode* node) { UNREACHABLE(); } void Parser::PatternRewriter::Visit(AstNode* node) { UNREACHABLE(); }
...@@ -395,7 +385,7 @@ NOT_A_PATTERN(CountOperation) ...@@ -395,7 +385,7 @@ NOT_A_PATTERN(CountOperation)
NOT_A_PATTERN(DebuggerStatement) NOT_A_PATTERN(DebuggerStatement)
NOT_A_PATTERN(DoWhileStatement) NOT_A_PATTERN(DoWhileStatement)
NOT_A_PATTERN(EmptyStatement) NOT_A_PATTERN(EmptyStatement)
NOT_A_PATTERN(SloppyBlockFunctionStatement) NOT_A_PATTERN(EmptyParentheses)
NOT_A_PATTERN(ExportDeclaration) NOT_A_PATTERN(ExportDeclaration)
NOT_A_PATTERN(ExpressionStatement) NOT_A_PATTERN(ExpressionStatement)
NOT_A_PATTERN(ForInStatement) NOT_A_PATTERN(ForInStatement)
...@@ -410,6 +400,8 @@ NOT_A_PATTERN(NativeFunctionLiteral) ...@@ -410,6 +400,8 @@ NOT_A_PATTERN(NativeFunctionLiteral)
NOT_A_PATTERN(Property) NOT_A_PATTERN(Property)
NOT_A_PATTERN(RegExpLiteral) NOT_A_PATTERN(RegExpLiteral)
NOT_A_PATTERN(ReturnStatement) NOT_A_PATTERN(ReturnStatement)
NOT_A_PATTERN(SloppyBlockFunctionStatement)
NOT_A_PATTERN(Spread)
NOT_A_PATTERN(SuperPropertyReference) NOT_A_PATTERN(SuperPropertyReference)
NOT_A_PATTERN(SuperCallReference) NOT_A_PATTERN(SuperCallReference)
NOT_A_PATTERN(SwitchStatement) NOT_A_PATTERN(SwitchStatement)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment