Commit c1bf25bb authored by Sigurd Schneider's avatar Sigurd Schneider Committed by Commit Bot

Enable 31bit Smis everywhere

This is a experiment to see how performance is impacted. If we tank
too much, we can revert this change.

Change-Id: I01be33f5dd78aee6a5beecdc62adbaa6c3850eb1
Bug: v8:8344
Reviewed-on: https://chromium-review.googlesource.com/c/1355279
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58157}
parent 5d8eefe9
...@@ -98,7 +98,6 @@ declare_args() { ...@@ -98,7 +98,6 @@ declare_args() {
# Enable pointer compression (sets -dV8_COMPRESS_POINTERS). # Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
v8_enable_pointer_compression = false v8_enable_pointer_compression = false
v8_enable_31bit_smis_on_64bit_arch = false
# Interpreted regexp engine exists as platform-independent alternative # Interpreted regexp engine exists as platform-independent alternative
# based where the regular expression is compiled to a bytecode. # based where the regular expression is compiled to a bytecode.
...@@ -344,9 +343,6 @@ config("features") { ...@@ -344,9 +343,6 @@ config("features") {
if (v8_enable_pointer_compression) { if (v8_enable_pointer_compression) {
defines += [ "V8_COMPRESS_POINTERS" ] defines += [ "V8_COMPRESS_POINTERS" ]
} }
if (v8_enable_31bit_smis_on_64bit_arch) {
defines += [ "V8_31BIT_SMIS_ON_64BIT_ARCH" ]
}
if (v8_enable_object_print) { if (v8_enable_object_print) {
defines += [ "OBJECT_PRINT" ] defines += [ "OBJECT_PRINT" ]
} }
......
...@@ -92,11 +92,7 @@ static_assert( ...@@ -92,11 +92,7 @@ static_assert(
"Pointer compression can be enabled only for 64-bit architectures"); "Pointer compression can be enabled only for 64-bit architectures");
#endif #endif
#if defined(V8_COMPRESS_POINTERS) || defined(V8_31BIT_SMIS_ON_64BIT_ARCH)
typedef SmiTagging<kApiIntSize> PlatformSmiTagging; typedef SmiTagging<kApiIntSize> PlatformSmiTagging;
#else
typedef SmiTagging<kApiSystemPointerSize> PlatformSmiTagging;
#endif
const int kSmiShiftSize = PlatformSmiTagging::kSmiShiftSize; const int kSmiShiftSize = PlatformSmiTagging::kSmiShiftSize;
const int kSmiValueSize = PlatformSmiTagging::kSmiValueSize; const int kSmiValueSize = PlatformSmiTagging::kSmiValueSize;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment