[Intl] Not harden the array return by supportedLocalesOf

see spec change in
https://github.com/tc39/ecma402/pull/278/

Bug: v8:8398
Change-Id: If5582f96d6dc3debdccb466d3d239efa52bbbf06
Reviewed-on: https://chromium-review.googlesource.com/c/1404436
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58717}

src/objects/intl-objects.cc

@@ -1324,35 +1324,6 @@ Handle<JSArray> CreateArrayFromList(Isolate* isolate,
   return array;
 }
 
-// TODO(bstell): should this be moved somewhere where it is reusable?
-// Implement steps 5, 6, 7 for ECMA 402 9.2.9 SupportedLocales
-// https://tc39.github.io/ecma402/#sec-supportedlocales
-MaybeHandle<JSObject> CreateReadOnlyArray(Isolate* isolate,
-                                          std::vector<std::string> elements) {
-  if (elements.size() >= kMaxUInt32) {
-    THROW_NEW_ERROR(
-        isolate, NewRangeError(MessageTemplate::kInvalidArrayLength), JSObject);
-  }
-
-  PropertyAttributes attr =
-      static_cast<PropertyAttributes>(READ_ONLY | DONT_DELETE);
-
-  // 5. Let subset be CreateArrayFromList(elements).
-  Handle<JSArray> subset = CreateArrayFromList(isolate, elements, attr);
-
-  // 6. Let keys be subset.[[OwnPropertyKeys]]().
-
-  // 7.a. Let desc be PropertyDescriptor { [[Configurable]]: false,
-  //          [[Writable]]: false }.
-  PropertyDescriptor desc;
-  desc.set_writable(false);
-  desc.set_configurable(false);
-
-  // 7.b. Perform ! DefinePropertyOrThrow(subset, P, desc).
-  JSArray::ArraySetLength(isolate, subset, &desc, kThrowOnError).ToChecked();
-  return subset;
-}
-
 // ECMA 402 9.2.9 SupportedLocales(availableLocales, requestedLocales, options)
 // https://tc39.github.io/ecma402/#sec-supportedlocales
 MaybeHandle<JSObject> SupportedLocales(
@@ -1394,22 +1365,11 @@ MaybeHandle<JSObject> SupportedLocales(
         LookupSupportedLocales(available_locales, requested_locales);
   }
 
-  // TODO(jkummerow): Possibly revisit why the spec has the individual entries
-  // readonly but the array is not frozen.
-  // https://github.com/tc39/ecma402/issues/258
-
-  // 5. Let subset be CreateArrayFromList(supportedLocales).
-  // 6. Let keys be subset.[[OwnPropertyKeys]]().
-  // 7. For each element P of keys in List order, do
-  //    a. Let desc be PropertyDescriptor { [[Configurable]]: false,
-  //       [[Writable]]: false }.
-  //    b. Perform ! DefinePropertyOrThrow(subset, P, desc).
-  MaybeHandle<JSObject> subset =
-      CreateReadOnlyArray(isolate, supported_locales);
-
-  // 8. Return subset.
-  return subset;
+  // 5. Return CreateArrayFromList(supportedLocales).
+  PropertyAttributes attr = static_cast<PropertyAttributes>(NONE);
+  return CreateArrayFromList(isolate, supported_locales, attr);
 }
+
 }  // namespace
 
 // ecma-402 #sec-intl.getcanonicallocales

test/test262/test262.status

@@ -529,6 +529,12 @@
   'language/expressions/call/eval-spread-empty-leading': [FAIL],
   'language/expressions/call/eval-spread-empty-trailing': [FAIL],
 
+  # https://bugs.chromium.org/p/v8/issues/detail?id=8398
+  'intl402/supportedLocalesOf-returned-array-elements-are-frozen': [FAIL],
+  'intl402/ListFormat/constructor/supportedLocalesOf/result-type': [FAIL],
+  'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/result-type': [FAIL],
+  'intl402/Segmenter/constructor/supportedLocalesOf/result-type': [FAIL],
+
   # https://bugs.chromium.org/p/v8/issues/detail?id=7472
   'intl402/NumberFormat/currency-digits': [FAIL],