[sparkplug] Enable short builtin calls by default

... when they are enabled via the GN flag.

Also disable this optimizaion for CFI builds for now.

Sheriffs: This CL adds ~1.2-1.4Mb of memory overhead per Isolate on
certain configurations and that's expected. This is a temporary fix
until the full solution is implemented.
See the design doc linked to the issue for details.

Bug: v8:11527
Change-Id: I7444c6878ea58d67ef580cf50cb550b3820c85c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2784690
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73650}

BUILD.gn

@@ -379,8 +379,10 @@ if (v8_multi_arch_build &&
   v8_enable_pointer_compression = !v8_enable_pointer_compression
   v8_enable_pointer_compression_shared_cage = v8_enable_pointer_compression
 }
-if (v8_enable_short_builtin_calls && !v8_enable_pointer_compression) {
+if (v8_enable_short_builtin_calls &&
+    (!v8_enable_pointer_compression || v8_control_flow_integrity)) {
   # Disable short calls when pointer compression is not enabled.
+  # Or when CFI is enabled (until the CFI-related issues are fixed).
   v8_enable_short_builtin_calls = false
 }
 if (v8_enable_shared_ro_heap == "") {

src/flags/flag-definitions.h

@@ -1546,7 +1546,7 @@ DEFINE_BOOL(experimental_flush_embedded_blob_icache, false,
 #define V8_SHORT_BUILTIN_CALLS_BOOL false
 #endif
 
-DEFINE_BOOL(short_builtin_calls, false,
+DEFINE_BOOL(short_builtin_calls, V8_SHORT_BUILTIN_CALLS_BOOL,
             "Put embedded builtins code into the code range for shorter "
             "builtin calls/jumps if system has >=4GB memory")