Commit c0a37514 authored by Andreas Haas's avatar Andreas Haas Committed by V8 LUCI CQ

[wasm] Disable lazy compilation in tests

Some tests assume lazy compilation is disabled.

Bug: v8:12852
Change-Id: I8e7bf0b7beeecf4ac385a458d7a178d0aa9cdbca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3811292Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82256}
parent c3ca8158
......@@ -299,10 +299,12 @@ void TestModuleSharingBetweenIsolates() {
}
UNINITIALIZED_TEST(TwoIsolatesShareNativeModule) {
FLAG_wasm_lazy_compilation = false;
TestModuleSharingBetweenIsolates();
}
UNINITIALIZED_TEST(TwoIsolatesShareNativeModuleWithPku) {
FLAG_wasm_lazy_compilation = false;
FLAG_wasm_memory_protection_keys = true;
TestModuleSharingBetweenIsolates();
}
......
......@@ -155,6 +155,7 @@ TEST(Run_WasmModule_CompilationHintsLazy) {
}
TEST(Run_WasmModule_CompilationHintsNoTiering) {
FlagScope<bool> no_lazy_compilation(&FLAG_wasm_lazy_compilation, false);
if (!FLAG_wasm_tier_up || !FLAG_liftoff) return;
{
EXPERIMENTAL_FLAG_SCOPE(compilation_hints);
......@@ -201,6 +202,7 @@ TEST(Run_WasmModule_CompilationHintsNoTiering) {
TEST(Run_WasmModule_CompilationHintsTierUp) {
FlagScope<bool> no_wasm_dynamic_tiering(&FLAG_wasm_dynamic_tiering, false);
FlagScope<bool> no_lazy_compilation(&FLAG_wasm_lazy_compilation, false);
if (!FLAG_wasm_tier_up || !FLAG_liftoff) return;
{
EXPERIMENTAL_FLAG_SCOPE(compilation_hints);
......@@ -261,6 +263,7 @@ TEST(Run_WasmModule_CompilationHintsTierUp) {
TEST(Run_WasmModule_CompilationHintsLazyBaselineEagerTopTier) {
FlagScope<bool> no_wasm_dynamic_tiering(&FLAG_wasm_dynamic_tiering, false);
FlagScope<bool> no_lazy_compilation(&FLAG_wasm_lazy_compilation, false);
if (!FLAG_wasm_tier_up || !FLAG_liftoff) return;
{
EXPERIMENTAL_FLAG_SCOPE(compilation_hints);
......
......@@ -334,9 +334,10 @@ COMPILE_TEST(TestEventMetrics) {
CHECK_LE(0, recorder->module_compiled_.back().wall_clock_duration_in_us);
CHECK_EQ(native_module->baseline_compilation_cpu_duration(),
recorder->module_compiled_.back().cpu_duration_in_us);
CHECK_IMPLIES(
v8::base::ThreadTicks::IsSupported() && !i::FLAG_wasm_test_streaming,
recorder->module_compiled_.back().cpu_duration_in_us > 0);
CHECK_IMPLIES(v8::base::ThreadTicks::IsSupported() &&
!i::FLAG_wasm_test_streaming &&
!i::FLAG_wasm_lazy_compilation,
recorder->module_compiled_.back().cpu_duration_in_us > 0);
CHECK_EQ(1, recorder->module_instantiated_.size());
CHECK(recorder->module_instantiated_.back().success);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment