[turbofan] Remove unnecessary code from frame state creation helpers

Change-Id: I65c1c5a75cde738f8fce33d2230fd12338f55154
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1783000Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63540}

src/compiler/bytecode-graph-builder.cc

@@ -1323,6 +1323,7 @@ void BytecodeGraphBuilder::VisitBytecodes() {
   }
 
   if (!FLAG_concurrent_inlining && has_one_shot_bytecode) {
+    // (For concurrent inlining this is done in the serializer instead.)
     isolate()->CountUsage(
         v8::Isolate::UseCounterFeature::kOptimizedFunctionWithOneShotBytecode);
   }

src/compiler/frame-states.cc

@@ -106,28 +106,22 @@ Node* CreateBuiltinContinuationFrameStateCommon(
     Node* closure, Node* context, Node** parameters, int parameter_count,
     Node* outer_frame_state,
     Handle<SharedFunctionInfo> shared = Handle<SharedFunctionInfo>()) {
-  Isolate* const isolate = jsgraph->isolate();
   Graph* const graph = jsgraph->graph();
   CommonOperatorBuilder* const common = jsgraph->common();
 
-  BailoutId bailout_id = Builtins::GetContinuationBailoutId(name);
-  Callable callable = Builtins::CallableFor(isolate, name);
-
   const Operator* op_param =
       common->StateValues(parameter_count, SparseInputMask::Dense());
   Node* params_node = graph->NewNode(op_param, parameter_count, parameters);
 
+  BailoutId bailout_id = Builtins::GetContinuationBailoutId(name);
   const FrameStateFunctionInfo* state_info =
       common->CreateFrameStateFunctionInfo(frame_type, parameter_count, 0,
                                            shared);
   const Operator* op = common->FrameState(
       bailout_id, OutputFrameStateCombine::Ignore(), state_info);
-
-  Node* frame_state = graph->NewNode(
-      op, params_node, jsgraph->EmptyStateValues(), jsgraph->EmptyStateValues(),
-      context, closure, outer_frame_state);
-
-  return frame_state;
+  return graph->NewNode(op, params_node, jsgraph->EmptyStateValues(),
+                        jsgraph->EmptyStateValues(), context, closure,
+                        outer_frame_state);
 }
 
 }  // namespace
@@ -136,8 +130,7 @@ Node* CreateStubBuiltinContinuationFrameState(
     JSGraph* jsgraph, Builtins::Name name, Node* context,
     Node* const* parameters, int parameter_count, Node* outer_frame_state,
     ContinuationFrameStateMode mode) {
-  Isolate* isolate = jsgraph->isolate();
-  Callable callable = Builtins::CallableFor(isolate, name);
+  Callable callable = Builtins::CallableFor(jsgraph->isolate(), name);
   CallInterfaceDescriptor descriptor = callable.descriptor();
 
   std::vector<Node*> actual_parameters;
@@ -172,9 +165,6 @@ Node* CreateJavaScriptBuiltinContinuationFrameState(
     Node* target, Node* context, Node* const* stack_parameters,
     int stack_parameter_count, Node* outer_frame_state,
     ContinuationFrameStateMode mode) {
-  Isolate* const isolate = jsgraph->isolate();
-  Callable const callable = Builtins::CallableFor(isolate, name);
-
   // Depending on {mode}, final parameters are added by the deoptimizer
   // and aren't explicitly passed in the frame state.
   DCHECK_EQ(Builtins::GetStackParameterCount(name) + 1,  // add receiver