Commit bc69917c authored by Sathya Gunasekaran's avatar Sathya Gunasekaran Committed by Commit Bot

Revert "[compiler] Replace Symbol with direct reads"

This reverts commit d3b295fa.

Reason for revert: speculative revert for https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/33146?

Original change's description:
> [compiler] Replace Symbol with direct reads
> 
> Bug: v8:7790
> Change-Id: I49120a6349777fd992a97d697940e79b2e71dbd1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2400988
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#69812}

TBR=neis@chromium.org,solanes@chromium.org

Change-Id: I10f69213e906e9b482ce4f8456ed7d5bcb039051
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7790
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2403256Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69815}
parent 79a14688
...@@ -59,8 +59,6 @@ enum class OddballType : uint8_t { ...@@ -59,8 +59,6 @@ enum class OddballType : uint8_t {
V(ObjectBoilerplateDescription) \ V(ObjectBoilerplateDescription) \
/* Subtypes of FixedArrayBase */ \ /* Subtypes of FixedArrayBase */ \
V(FixedDoubleArray) \ V(FixedDoubleArray) \
/* Subtypes of Name */ \
V(Symbol) \
/* Subtypes of HeapObject */ \ /* Subtypes of HeapObject */ \
V(ArrayBoilerplateDescription) \ V(ArrayBoilerplateDescription) \
V(HeapNumber) V(HeapNumber)
...@@ -89,6 +87,7 @@ enum class OddballType : uint8_t { ...@@ -89,6 +87,7 @@ enum class OddballType : uint8_t {
/* Subtypes of Name */ \ /* Subtypes of Name */ \
V(InternalizedString) \ V(InternalizedString) \
V(String) \ V(String) \
V(Symbol) \
/* Subtypes of JSReceiver */ \ /* Subtypes of JSReceiver */ \
V(JSObject) \ V(JSObject) \
/* Subtypes of HeapObject */ \ /* Subtypes of HeapObject */ \
......
...@@ -838,9 +838,7 @@ class StringData : public NameData { ...@@ -838,9 +838,7 @@ class StringData : public NameData {
class SymbolData : public NameData { class SymbolData : public NameData {
public: public:
SymbolData(JSHeapBroker* broker, ObjectData** storage, Handle<Symbol> object) SymbolData(JSHeapBroker* broker, ObjectData** storage, Handle<Symbol> object)
: NameData(broker, storage, object) { : NameData(broker, storage, object) {}
DCHECK(!FLAG_turbo_direct_heap_access);
}
}; };
StringData::StringData(JSHeapBroker* broker, ObjectData** storage, StringData::StringData(JSHeapBroker* broker, ObjectData** storage,
......
...@@ -1509,9 +1509,6 @@ struct TyperPhase { ...@@ -1509,9 +1509,6 @@ struct TyperPhase {
LoopVariableOptimizer induction_vars(data->jsgraph()->graph(), LoopVariableOptimizer induction_vars(data->jsgraph()->graph(),
data->common(), temp_zone); data->common(), temp_zone);
if (FLAG_turbo_loop_variable) induction_vars.Run(); if (FLAG_turbo_loop_variable) induction_vars.Run();
// The typer inspects heap objects, so we need to unpark the local heap.
UnparkedScopeIfNeeded scope(data->broker());
typer->Run(roots, &induction_vars); typer->Run(roots, &induction_vars);
} }
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment