Commit bc1aa934 authored by erik.corry@gmail.com's avatar erik.corry@gmail.com

Don't strength reduce divisions by 1 or 2 as they can often be

handled by an optimistic inline idiv.
Review URL: http://codereview.chromium.org/125258

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 2caf318d
......@@ -2653,10 +2653,15 @@ Expression* Parser::ParseBinaryExpression(int prec, bool accept_IN, bool* ok) {
double y_val = y->AsLiteral()->handle()->Number();
int64_t y_int = static_cast<int64_t>(y_val);
// There are rounding issues with this optimization, but they don't
// apply if the number to be divided with has a reciprocal that can
// be precisely represented as a floating point number. This is
// the case if the number is an integer power of 2.
if (static_cast<double>(y_int) == y_val && IsPowerOf2(y_int)) {
// apply if the number to be divided with has a reciprocal that can be
// precisely represented as a floating point number. This is the case
// if the number is an integer power of 2. Negative integer powers of
// 2 work too, but for -2, -1, 1 and 2 we don't do the strength
// reduction because the inlined optimistic idiv has a reasonable
// chance of succeeding by producing a Smi answer with no remainder.
if (static_cast<double>(y_int) == y_val &&
(IsPowerOf2(y_int) || IsPowerOf2(-y_int)) &&
(y_int > 2 || y_int < -2)) {
y = NewNumberLiteral(1 / y_val);
op = Token::MUL;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment