Commit bbd0a093 authored by rmcilroy's avatar rmcilroy Committed by Commit bot

Revert of [interpreter] Inline ForInFilter stub. (patchset #1 id:1 of...

Revert of [interpreter] Inline ForInFilter stub. (patchset #1 id:1 of https://codereview.chromium.org/2220343002/ )

Reason for revert:
Speculative revert to possible performance regressions.

BUG=chromium:635826,chromium:635930

Original issue's description:
> [interpreter] Inline ForInFilter stub.
>
> BUG=v8:4280
> LOG=N
>
> Committed: https://crrev.com/2bf0b8c8ed5d0c93982c8c227e93622aceecea16
> Cr-Commit-Position: refs/heads/master@{#38420}

TBR=oth@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:4280

Review-Url: https://codereview.chromium.org/2238283002
Cr-Commit-Position: refs/heads/master@{#38623}
parent dc6b5109
......@@ -2082,7 +2082,7 @@ void Interpreter::DoForInNext(InterpreterAssembler* assembler) {
CodeStubAssembler::SMI_PARAMETERS);
// Check if we can use the for-in fast path potentially using the enum cache.
Label if_fast(assembler), if_slow(assembler);
Label if_fast(assembler), if_slow(assembler, Label::kDeferred);
Node* receiver_map = __ LoadObjectField(receiver, HeapObject::kMapOffset);
__ BranchIfWordEqual(receiver_map, cache_type, &if_fast, &if_slow);
__ Bind(&if_fast);
......@@ -2103,7 +2103,8 @@ void Interpreter::DoForInNext(InterpreterAssembler* assembler) {
// Need to filter the {key} for the {receiver}.
Node* context = __ GetContext();
Node* result = ForInFilterStub::Generate(assembler, key, receiver, context);
Callable callable = CodeFactory::ForInFilter(assembler->isolate());
Node* result = __ CallStub(callable, context, key, receiver);
__ SetAccumulator(result);
__ Dispatch();
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment