Commit bb793c28 authored by Benedikt Meurer's avatar Benedikt Meurer Committed by Commit Bot

[turbofan] Remove unused LoadHashMapValue operator.

Change-Id: I22bf46718ef14450bf5c18948f70f1b9b58ae949
Reviewed-on: https://chromium-review.googlesource.com/706791Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48363}
parent 9019de38
...@@ -841,8 +841,6 @@ bool EffectControlLinearizer::TryWireInStateEffect(Node* node, ...@@ -841,8 +841,6 @@ bool EffectControlLinearizer::TryWireInStateEffect(Node* node,
case IrOpcode::kLookupSigned32HashStorageIndex: case IrOpcode::kLookupSigned32HashStorageIndex:
result = LowerLookupSigned32HashStorageIndex(node); result = LowerLookupSigned32HashStorageIndex(node);
break; break;
case IrOpcode::kLoadHashMapValue:
result = LowerLoadHashMapValue(node);
case IrOpcode::kTransitionAndStoreElement: case IrOpcode::kTransitionAndStoreElement:
LowerTransitionAndStoreElement(node); LowerTransitionAndStoreElement(node);
break; break;
...@@ -3680,12 +3678,6 @@ Node* EffectControlLinearizer::LowerLookupSigned32HashStorageIndex(Node* node) { ...@@ -3680,12 +3678,6 @@ Node* EffectControlLinearizer::LowerLookupSigned32HashStorageIndex(Node* node) {
return done.PhiAt(0); return done.PhiAt(0);
} }
Node* EffectControlLinearizer::LowerLoadHashMapValue(Node* node) {
Node* table = NodeProperties::GetValueInput(node, 0);
Node* index = NodeProperties::GetValueInput(node, 1);
return __ LoadElement(AccessBuilder::ForFixedArrayElement(), table, index);
}
#undef __ #undef __
Factory* EffectControlLinearizer::factory() const { Factory* EffectControlLinearizer::factory() const {
......
...@@ -127,7 +127,6 @@ class V8_EXPORT_PRIVATE EffectControlLinearizer { ...@@ -127,7 +127,6 @@ class V8_EXPORT_PRIVATE EffectControlLinearizer {
void LowerStoreTypedElement(Node* node); void LowerStoreTypedElement(Node* node);
Node* LowerLookupHashStorageIndex(Node* node); Node* LowerLookupHashStorageIndex(Node* node);
Node* LowerLookupSigned32HashStorageIndex(Node* node); Node* LowerLookupSigned32HashStorageIndex(Node* node);
Node* LowerLoadHashMapValue(Node* node);
void LowerTransitionAndStoreElement(Node* node); void LowerTransitionAndStoreElement(Node* node);
void LowerRuntimeAbort(Node* node); void LowerRuntimeAbort(Node* node);
......
...@@ -375,7 +375,6 @@ ...@@ -375,7 +375,6 @@
V(TransitionElementsKind) \ V(TransitionElementsKind) \
V(LookupHashStorageIndex) \ V(LookupHashStorageIndex) \
V(LookupSigned32HashStorageIndex) \ V(LookupSigned32HashStorageIndex) \
V(LoadHashMapValue) \
V(RuntimeAbort) V(RuntimeAbort)
#define SIMPLIFIED_OP_LIST(V) \ #define SIMPLIFIED_OP_LIST(V) \
......
...@@ -2933,12 +2933,6 @@ class RepresentationSelector { ...@@ -2933,12 +2933,6 @@ class RepresentationSelector {
return; return;
} }
case IrOpcode::kLoadHashMapValue:
ProcessInput(node, 0, UseInfo::AnyTagged()); // table
ProcessInput(node, 1, UseInfo::TruncatingWord32()); // index
ProcessRemainingInputs(node, 2);
return SetOutput(node, MachineRepresentation::kTagged);
// Operators with all inputs tagged and no or tagged output have uniform // Operators with all inputs tagged and no or tagged output have uniform
// handling. // handling.
case IrOpcode::kEnd: case IrOpcode::kEnd:
......
...@@ -604,13 +604,6 @@ struct SimplifiedOperatorGlobalCache final { ...@@ -604,13 +604,6 @@ struct SimplifiedOperatorGlobalCache final {
}; };
LookupSigned32HashStorageIndexOperator kLookupSigned32HashStorageIndex; LookupSigned32HashStorageIndexOperator kLookupSigned32HashStorageIndex;
struct LoadHashMapValueOperator final : public Operator {
LoadHashMapValueOperator()
: Operator(IrOpcode::kLoadHashMapValue, Operator::kEliminatable,
"LoadHashMapValue", 2, 1, 1, 1, 1, 0) {}
};
LoadHashMapValueOperator kLoadHashMapValue;
struct ArgumentsFrameOperator final : public Operator { struct ArgumentsFrameOperator final : public Operator {
ArgumentsFrameOperator() ArgumentsFrameOperator()
: Operator(IrOpcode::kArgumentsFrame, Operator::kPure, "ArgumentsFrame", : Operator(IrOpcode::kArgumentsFrame, Operator::kPure, "ArgumentsFrame",
...@@ -789,7 +782,6 @@ GET_FROM_CACHE(ArrayBufferWasNeutered) ...@@ -789,7 +782,6 @@ GET_FROM_CACHE(ArrayBufferWasNeutered)
GET_FROM_CACHE(ArgumentsFrame) GET_FROM_CACHE(ArgumentsFrame)
GET_FROM_CACHE(LookupHashStorageIndex) GET_FROM_CACHE(LookupHashStorageIndex)
GET_FROM_CACHE(LookupSigned32HashStorageIndex) GET_FROM_CACHE(LookupSigned32HashStorageIndex)
GET_FROM_CACHE(LoadHashMapValue)
GET_FROM_CACHE(LoadFieldByIndex) GET_FROM_CACHE(LoadFieldByIndex)
#undef GET_FROM_CACHE #undef GET_FROM_CACHE
......
...@@ -375,7 +375,6 @@ class V8_EXPORT_PRIVATE SimplifiedOperatorBuilder final ...@@ -375,7 +375,6 @@ class V8_EXPORT_PRIVATE SimplifiedOperatorBuilder final
const Operator* LookupHashStorageIndex(); const Operator* LookupHashStorageIndex();
const Operator* LookupSigned32HashStorageIndex(); const Operator* LookupSigned32HashStorageIndex();
const Operator* LoadHashMapValue();
const Operator* SpeculativeToNumber(NumberOperationHint hint); const Operator* SpeculativeToNumber(NumberOperationHint hint);
......
...@@ -2058,10 +2058,6 @@ Type* Typer::Visitor::TypeLookupSigned32HashStorageIndex(Node* node) { ...@@ -2058,10 +2058,6 @@ Type* Typer::Visitor::TypeLookupSigned32HashStorageIndex(Node* node) {
return Type::SignedSmall(); return Type::SignedSmall();
} }
Type* Typer::Visitor::TypeLoadHashMapValue(Node* node) {
return Type::NonInternal();
}
Type* Typer::Visitor::TypeRuntimeAbort(Node* node) { UNREACHABLE(); } Type* Typer::Visitor::TypeRuntimeAbort(Node* node) { UNREACHABLE(); }
// Heap constants. // Heap constants.
......
...@@ -1030,10 +1030,6 @@ void Verifier::Visitor::Check(Node* node) { ...@@ -1030,10 +1030,6 @@ void Verifier::Visitor::Check(Node* node) {
CheckValueInputIs(node, 1, Type::Signed32()); CheckValueInputIs(node, 1, Type::Signed32());
CheckTypeIs(node, Type::SignedSmall()); CheckTypeIs(node, Type::SignedSmall());
break; break;
case IrOpcode::kLoadHashMapValue:
CheckValueInputIs(node, 2, Type::SignedSmall());
CheckTypeIs(node, Type::SignedSmall());
break;
case IrOpcode::kArgumentsLength: case IrOpcode::kArgumentsLength:
CheckValueInputIs(node, 0, Type::ExternalPointer()); CheckValueInputIs(node, 0, Type::ExternalPointer());
CheckTypeIs(node, TypeCache::Get().kArgumentsLengthType); CheckTypeIs(node, TypeCache::Get().kArgumentsLengthType);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment