Commit baa7bc0f authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[heap] Remove dead RecordCodeTargetPatch support.

R=mlippautz@chromium.org
BUG=v8:6409

Change-Id: I0cdba60385c8b481a3fd7b1b5c3b2ba1b0b8367b
Reviewed-on: https://chromium-review.googlesource.com/628059Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47542}
parent 8bbc2242
......@@ -86,26 +86,6 @@ int IncrementalMarking::RecordWriteFromCode(HeapObject* obj, Object** slot,
return 0;
}
void IncrementalMarking::RecordCodeTargetPatch(Code* host, Address pc,
HeapObject* value) {
if (IsMarking()) {
RelocInfo rinfo(pc, RelocInfo::CODE_TARGET, 0, host);
RecordWriteIntoCode(host, &rinfo, value);
}
}
void IncrementalMarking::RecordCodeTargetPatch(Address pc, HeapObject* value) {
if (IsMarking()) {
Code* host = heap_->isolate()
->inner_pointer_to_code_cache()
->GcSafeFindCodeForInnerPointer(pc);
RelocInfo rinfo(pc, RelocInfo::CODE_TARGET, 0, host);
RecordWriteIntoCode(host, &rinfo, value);
}
}
void IncrementalMarking::RecordWriteIntoCodeSlow(Code* host, RelocInfo* rinfo,
Object* value) {
if (BaseRecordWrite(host, value)) {
......
......@@ -233,8 +233,6 @@ class V8_EXPORT_PRIVATE IncrementalMarking {
void RecordWriteSlow(HeapObject* obj, Object** slot, Object* value);
void RecordWriteIntoCodeSlow(Code* host, RelocInfo* rinfo, Object* value);
void RecordCodeTargetPatch(Code* host, Address pc, HeapObject* value);
void RecordCodeTargetPatch(Address pc, HeapObject* value);
// Returns true if the function succeeds in transitioning the object
// from white to grey.
......
......@@ -4619,22 +4619,5 @@ void MarkCompactCollector::StartSweepSpaces() {
heap_->lo_space()->FreeUnmarkedObjects();
}
void MarkCompactCollector::RecordCodeTargetPatch(Address pc, Code* target) {
DCHECK(heap()->gc_state() == Heap::MARK_COMPACT);
if (is_compacting()) {
Code* host =
isolate()->inner_pointer_to_code_cache()->GcSafeFindCodeForInnerPointer(
pc);
if (non_atomic_marking_state()->IsBlack(host)) {
RelocInfo rinfo(pc, RelocInfo::CODE_TARGET, 0, host);
// The target is always in old space, we don't have to record the slot in
// the old-to-new remembered set.
DCHECK(!heap()->InNewSpace(target));
RecordRelocSlot(host, &rinfo, target);
}
}
}
} // namespace internal
} // namespace v8
......@@ -698,7 +698,6 @@ class MarkCompactCollector final : public MarkCompactCollectorBase {
}
void RecordRelocSlot(Code* host, RelocInfo* rinfo, Object* target);
void RecordCodeTargetPatch(Address pc, Code* target);
V8_INLINE static void RecordSlot(HeapObject* object, Object** slot,
Object* target);
void RecordLiveSlotsOnPage(Page* page);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment