Commit ba713b8e authored by Camillo Bruni's avatar Camillo Bruni Committed by V8 LUCI CQ

[torque] Emit full codesearch links for source positions

Change-Id: I80affc4c813dff2a42afcdcea60e3856eaf346aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272576Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77841}
parent 77d9e997
......@@ -109,7 +109,8 @@ inline std::string PositionAsString(SourcePosition pos) {
}
inline std::ostream& operator<<(std::ostream& out, SourcePosition pos) {
return out << SourceFileMap::PathFromV8Root(pos.source)
return out << "https://source.chromium.org/chromium/chromium/src/+/main:v8/"
<< SourceFileMap::PathFromV8Root(pos.source)
<< "?l=" << (pos.start.line + 1)
<< "&c=" << (pos.start.column + 1);
}
......
......@@ -447,7 +447,8 @@ def load_objects_from_file(objfilename, checktypes):
in_torque_fulldef = False
continue
line = re.sub('//.*', '', line.strip());
pre = line.strip()
line = re.sub('// .*', '', line.strip());
if (in_insttype):
typestr += line;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment