Commit ba40bf7a authored by kschimpf's avatar kschimpf Committed by Commit bot

Separate module compile counter for asm and wasm.

Currently, v8 uses the same flag to collect time for compiling wasm modules from js asm and wasm. This separates the v8 counter into two separate counters, and then uses the appropriate counter when compiling a module.

Note: This CL doesn't separate the corresponding Chromium counter. Rather that is intenionally being delayed until v8 code has separated all appropriate counters for js asm and wasm. That way, the installation into chrome can be done at once.

BUG=chromium:704922
R=bradnelson@chromium.org,bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2778493002
Cr-Commit-Position: refs/heads/master@{#44126}
parent 74c7dd0b
......@@ -966,7 +966,10 @@ class RuntimeCallTimerScope {
MICROSECOND) \
HT(wasm_decode_function_time, V8.WasmDecodeFunctionMicroSeconds, 1000000, \
MICROSECOND) \
HT(wasm_compile_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \
/* TODO(kschimpf) Update chrome flags to reflect asm/wasm split. */ \
HT(wasm_compile_asm_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \
MICROSECOND) \
HT(wasm_compile_wasm_module_time, V8.WasmCompileModuleMicroSeconds, 1000000, \
MICROSECOND) \
HT(wasm_compile_function_time, V8.WasmCompileFunctionMicroSeconds, 1000000, \
MICROSECOND) \
......
......@@ -514,7 +514,9 @@ class CompilationHelper {
}
HistogramTimerScope wasm_compile_module_time_scope(
isolate_->counters()->wasm_compile_module_time());
module_->origin == ModuleOrigin::kWasmOrigin
? isolate_->counters()->wasm_compile_wasm_module_time()
: isolate_->counters()->wasm_compile_asm_module_time());
ModuleBytesEnv module_env(module_, &temp_instance, wire_bytes);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment