[wasm] [cleanup] Pass unique_ptr by value

According to the style guide, we pass unique_ptr by value, or by
reference in rare cases, but never by rvalue reference.

R=ahaas@chromium.org

Bug: v8:7109
Change-Id: I6cfdb8b61fada532ce334e2da419598085a2b408
Reviewed-on: https://chromium-review.googlesource.com/803716Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49820}

src/wasm/wasm-heap.cc

@@ -266,7 +266,7 @@ uint32_t NativeModule::FunctionCount() const {
 
 WasmCode* NativeModule::AddOwnedCode(
     Vector<const byte> orig_instructions,
-    std::unique_ptr<const byte[]>&& reloc_info, size_t reloc_size,
+    std::unique_ptr<const byte[]> reloc_info, size_t reloc_size,
     Maybe<uint32_t> index, WasmCode::Kind kind, size_t constant_pool_offset,
     uint32_t stack_slots, size_t safepoint_table_offset,
     std::shared_ptr<ProtectedInstructions> protected_instructions,
@@ -281,7 +281,7 @@ WasmCode* NativeModule::AddOwnedCode(
   std::unique_ptr<WasmCode> code(new WasmCode(
       {executable_buffer, orig_instructions.size()}, std::move(reloc_info),
       reloc_size, this, index, kind, constant_pool_offset, stack_slots,
-      safepoint_table_offset, protected_instructions, is_liftoff));
+      safepoint_table_offset, std::move(protected_instructions), is_liftoff));
   WasmCode* ret = code.get();
 
   // TODO(mtrofin): We allocate in increasing address order, and
@@ -392,7 +392,8 @@ WasmCode* NativeModule::AddCode(
       {desc.buffer, static_cast<size_t>(desc.instr_size)},
       std::move(reloc_info), static_cast<size_t>(desc.reloc_size), Just(index),
       WasmCode::kFunction, desc.instr_size - desc.constant_pool_size,
-      frame_slots, safepoint_table_offset, protected_instructions, is_liftoff);
+      frame_slots, safepoint_table_offset, std::move(protected_instructions),
+      is_liftoff);
   if (ret == nullptr) return nullptr;
 
   SetCodeTable(index, ret);

src/wasm/wasm-heap.h

@@ -295,7 +295,7 @@ class V8_EXPORT_PRIVATE NativeModule final {
   // code is obtained (CodeDesc vs, as a point in time, Code*), the kind,
   // whether it has an index or is anonymous, etc.
   WasmCode* AddOwnedCode(Vector<const byte> orig_instructions,
-                         std::unique_ptr<const byte[]>&& reloc_info,
+                         std::unique_ptr<const byte[]> reloc_info,
                          size_t reloc_size, Maybe<uint32_t> index,
                          WasmCode::Kind kind, size_t constant_pool_offset,
                          uint32_t stack_slots, size_t safepoint_table_offset,