Commit b952ea16 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by V8 LUCI CQ

[compiler] Skip MapRef descriptor array's serialize methods

We don't need to serialize the descriptor array when concurrent
inlining so we can skip the methods related to serializing.

While doing so we bumped into two broken tests in serializer-tester.
Since we are planning on removing the serializer soon, it makes more
sense to remove them than trying to fix them.

Bug: v8:7790
Change-Id: Ib1feea16f09edebbd9927afc4178ed10f85fd42f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2975300
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75307}
parent 07e6b125
......@@ -4561,7 +4561,9 @@ base::Optional<MapRef> JSObjectRef::GetObjectCreateMap() const {
bool MapRef::TrySerializeOwnDescriptor(InternalIndex descriptor_index) {
CHECK_LT(descriptor_index.as_int(), NumberOfOwnDescriptors());
if (data_->should_access_heap()) return true;
if (data_->should_access_heap() || broker()->is_concurrent_inlining()) {
return true;
}
CHECK_IMPLIES(!FLAG_turbo_concurrent_get_property_access_info,
broker()->mode() == JSHeapBroker::kSerializing);
return data()->AsMap()->TrySerializeOwnDescriptor(broker(), descriptor_index);
......@@ -4573,7 +4575,9 @@ void MapRef::SerializeOwnDescriptor(InternalIndex descriptor_index) {
bool MapRef::serialized_own_descriptor(InternalIndex descriptor_index) const {
CHECK_LT(descriptor_index.as_int(), NumberOfOwnDescriptors());
if (data_->should_access_heap()) return true;
if (data_->should_access_heap() || broker()->is_concurrent_inlining()) {
return true;
}
ObjectData* maybe_desc_array_data = data()->AsMap()->instance_descriptors();
if (!maybe_desc_array_data) return false;
if (maybe_desc_array_data->should_access_heap()) return true;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment