[compiler] Revert to serialization for some classes

Reverted:
 * FixedDoubleArray
 * BigInt
 * HeapNumber
 * Partial work of JSDataView

Bug: v8:7790
Change-Id: I075e1d6d50129771f6208f198911797c6db3b7cb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431944
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70187}

src/compiler/heap-refs.h

@@ -60,16 +60,12 @@ enum class OddballType : uint8_t {
 #define HEAP_BROKER_NEVER_SERIALIZED_OBJECT_LIST(V) \
   /* Subtypes of FixedArray */                      \
   V(ObjectBoilerplateDescription)                   \
-  /* Subtypes of FixedArrayBase */                  \
-  V(FixedDoubleArray)                               \
   /* Subtypes of Name */                            \
   V(Symbol)                                         \
   /* Subtypes of HeapObject */                      \
   V(AccessorInfo)                                   \
   V(ArrayBoilerplateDescription)                    \
-  V(BigInt)                                         \
   V(Cell)                                           \
-  V(HeapNumber)                                     \
   V(TemplateObjectDescription)
 
 // This list is sorted such that subtypes appear before their supertypes.
@@ -93,6 +89,7 @@ enum class OddballType : uint8_t {
   /* Subtypes of FixedArrayBase */            \
   V(BytecodeArray)                            \
   V(FixedArray)                               \
+  V(FixedDoubleArray)                         \
   /* Subtypes of Name */                      \
   V(InternalizedString)                       \
   V(String)                                   \
@@ -100,6 +97,7 @@ enum class OddballType : uint8_t {
   V(JSObject)                                 \
   /* Subtypes of HeapObject */                \
   V(AllocationSite)                           \
+  V(BigInt)                                   \
   V(CallHandlerInfo)                          \
   V(Code)                                     \
   V(DescriptorArray)                          \
@@ -107,6 +105,7 @@ enum class OddballType : uint8_t {
   V(FeedbackVector)                           \
   V(FixedArrayBase)                           \
   V(FunctionTemplateInfo)                     \
+  V(HeapNumber)                               \
   V(JSReceiver)                               \
   V(Map)                                      \
   V(Name)                                     \

src/compiler/js-heap-broker.cc

@@ -705,7 +705,6 @@ class HeapNumberData : public HeapObjectData {
   HeapNumberData(JSHeapBroker* broker, ObjectData** storage,
                  Handle<HeapNumber> object)
       : HeapObjectData(broker, storage, object), value_(object->value()) {
-    DCHECK(!FLAG_turbo_direct_heap_access);
   }
 
   double value() const { return value_; }
@@ -1021,7 +1020,6 @@ class BigIntData : public HeapObjectData {
   BigIntData(JSHeapBroker* broker, ObjectData** storage, Handle<BigInt> object)
       : HeapObjectData(broker, storage, object),
         as_uint64_(object->AsUint64(nullptr)) {
-    DCHECK(!FLAG_turbo_direct_heap_access);
   }
 
   uint64_t AsUint64() const { return as_uint64_; }
@@ -1575,7 +1573,6 @@ FixedDoubleArrayData::FixedDoubleArrayData(JSHeapBroker* broker,
                                            ObjectData** storage,
                                            Handle<FixedDoubleArray> object)
     : FixedArrayBaseData(broker, storage, object), contents_(broker->zone()) {
-  DCHECK(!FLAG_turbo_direct_heap_access);
 }
 
 void FixedDoubleArrayData::SerializeContents(JSHeapBroker* broker) {
@@ -3361,7 +3358,7 @@ BIMODAL_ACCESSOR(JSBoundFunction, JSReceiver, bound_target_function)
 BIMODAL_ACCESSOR(JSBoundFunction, Object, bound_this)
 BIMODAL_ACCESSOR(JSBoundFunction, FixedArray, bound_arguments)
 
-BIMODAL_ACCESSOR_WITH_FLAG_C(JSDataView, size_t, byte_length)
+BIMODAL_ACCESSOR_C(JSDataView, size_t, byte_length)
 
 BIMODAL_ACCESSOR_C(JSFunction, bool, has_feedback_vector)
 BIMODAL_ACCESSOR_C(JSFunction, bool, has_initial_map)