Commit b8cbe08f authored by ricow@chromium.org's avatar ricow@chromium.org

Fix presubmit errors caused by updated depot tools

This is all blank line before/after linting errors.
Review URL: http://codereview.chromium.org/7754022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 78ce35ef
......@@ -77,7 +77,6 @@ class HttpRequestProcessor {
*/
class JsHttpRequestProcessor : public HttpRequestProcessor {
public:
// Creates a new processor that processes requests by invoking the
// Process function of the JavaScript script given as an argument.
explicit JsHttpRequestProcessor(Handle<String> script) : script_(script) { }
......@@ -88,7 +87,6 @@ class JsHttpRequestProcessor : public HttpRequestProcessor {
virtual bool Process(HttpRequest* req);
private:
// Execute the script associated with this processor and extract the
// Process function. Returns true if this succeeded, otherwise false.
bool ExecuteScript(Handle<String> script);
......
......@@ -710,6 +710,7 @@ class FrameFunctionIterator {
} while (next_function != NULL);
return false;
}
private:
void GetFunctions() {
functions_.Rewind(0);
......
......@@ -75,6 +75,7 @@ class Arguments BASE_EMBEDDED {
int length() const { return length_; }
Object** arguments() { return arguments_; }
private:
int length_;
Object** arguments_;
......
......@@ -40,7 +40,6 @@ class LGapResolver;
class LGapResolver BASE_EMBEDDED {
public:
explicit LGapResolver(LCodeGen* owner);
// Resolve a set of parallel moves, emitting assembler instructions.
......
......@@ -116,6 +116,7 @@ class RegExpMacroAssemblerARM: public NativeRegExpMacroAssembler {
static int CheckStackGuardState(Address* return_address,
Code* re_code,
Address re_frame);
private:
// Offsets from frame_pointer() of function parameters and stored registers.
static const int kFramePointer = 0;
......
......@@ -92,6 +92,7 @@ class Bignum {
static bool PlusLess(const Bignum& a, const Bignum& b, const Bignum& c) {
return PlusCompare(a, b, c) < 0;
}
private:
typedef uint32_t Chunk;
typedef uint64_t DoubleChunk;
......
......@@ -35,7 +35,6 @@ namespace internal {
class PowersOfTenCache {
public:
// Not all powers of ten are cached. The decimal exponent of two neighboring
// cached numbers will differ by kDecimalExponentDistance.
static const int kDecimalExponentDistance;
......
......@@ -242,6 +242,7 @@ class CompilationCache {
// cache during debugging to make sure new scripts are always compiled.
void Enable();
void Disable();
private:
explicit CompilationCache(Isolate* isolate);
~CompilationCache();
......
......@@ -231,6 +231,7 @@ class ExecArgs {
static const unsigned kMaxArgs = 1000;
char** arg_array() { return exec_args_; }
char* arg0() { return exec_args_[0]; }
private:
char* exec_args_[kMaxArgs + 1];
};
......
......@@ -208,6 +208,7 @@ class Shell {
#else
class Shell : public i::AllStatic {
#endif // V8_SHARED
public:
static bool ExecuteString(Handle<String> source,
Handle<Value> name,
......
......@@ -36,7 +36,6 @@ namespace internal {
class DateParser : public AllStatic {
public:
// Parse the string as a date. If parsing succeeds, return true after
// filling out the output array as follows (all integers are Smis):
// [0]: year
......@@ -234,6 +233,7 @@ class DateParser : public AllStatic {
static DateToken Invalid() {
return DateToken(kInvalidTokenTag, 0, -1);
}
private:
enum TagType {
kInvalidTokenTag = -6,
......@@ -275,6 +275,7 @@ class DateParser : public AllStatic {
}
return false;
}
private:
DateToken Scan();
......@@ -351,6 +352,7 @@ class DateParser : public AllStatic {
static bool IsMinute(int x) { return Between(x, 0, 59); }
static bool IsHour(int x) { return Between(x, 0, 23); }
static bool IsSecond(int x) { return Between(x, 0, 59); }
private:
static bool IsHour12(int x) { return Between(x, 0, 12); }
static bool IsMillisecond(int x) { return Between(x, 0, 999); }
......
......@@ -1026,6 +1026,7 @@ class Debug_Address {
return NULL;
}
}
private:
Debug::AddressId id_;
};
......
......@@ -579,6 +579,7 @@ class ArgumentsAdaptorFrame: public JavaScriptFrame {
virtual void Print(StringStream* accumulator,
PrintMode mode,
int index) const;
protected:
explicit ArgumentsAdaptorFrame(StackFrameIterator* iterator)
: JavaScriptFrame(iterator) { }
......
......@@ -465,6 +465,7 @@ class CpuFeatures : public AllStatic {
// Enable a specified feature within a scope.
class Scope BASE_EMBEDDED {
#ifdef DEBUG
public:
explicit Scope(CpuFeature f) {
uint64_t mask = static_cast<uint64_t>(1) << f;
......@@ -484,10 +485,12 @@ class CpuFeatures : public AllStatic {
isolate_->set_enabled_cpu_features(old_enabled_);
}
}
private:
Isolate* isolate_;
uint64_t old_enabled_;
#else
public:
explicit Scope(CpuFeature f) {}
#endif
......
......@@ -41,7 +41,6 @@ namespace internal {
class Inspector {
public:
static void DumpObjectType(FILE* out, Object *obj, bool print_more);
static void DumpObjectType(FILE* out, Object *obj) {
DumpObjectType(out, obj, false);
......@@ -59,4 +58,3 @@ class Inspector {
#endif // INSPECTOR
#endif // V8_INSPECTOR_H_
......@@ -255,6 +255,7 @@ class SetRelation BASE_EMBEDDED {
return (bits_ == (kInFirst | kInSecond | kInBoth));
}
int value() { return bits_; }
private:
int bits_;
};
......@@ -404,6 +405,7 @@ class DispatchTable : public ZoneObject {
template <typename Callback>
void ForEach(Callback* callback) { return tree()->ForEach(callback); }
private:
// There can't be a static empty set since it allocates its
// successors in a zone and caches them.
......@@ -793,6 +795,7 @@ class ActionNode: public SeqRegExpNode {
virtual int GreedyLoopTextLength() { return kNodeIsTooComplexForGreedyLoops; }
virtual ActionNode* Clone() { return new ActionNode(*this); }
virtual int ComputeFirstCharacterSet(int budget);
private:
union {
struct {
......@@ -861,6 +864,7 @@ class TextNode: public SeqRegExpNode {
}
void CalculateOffsets();
virtual int ComputeFirstCharacterSet(int budget);
private:
enum TextEmitPassType {
NON_ASCII_MATCH, // Check for characters that can't match.
......@@ -925,6 +929,7 @@ class AssertionNode: public SeqRegExpNode {
virtual AssertionNode* Clone() { return new AssertionNode(*this); }
AssertionNodeType type() { return type_; }
void set_type(AssertionNodeType type) { type_ = type; }
private:
AssertionNode(AssertionNodeType t, RegExpNode* on_success)
: SeqRegExpNode(on_success), type_(t) { }
......@@ -955,6 +960,7 @@ class BackReferenceNode: public SeqRegExpNode {
}
virtual BackReferenceNode* Clone() { return new BackReferenceNode(*this); }
virtual int ComputeFirstCharacterSet(int budget);
private:
int start_reg_;
int end_reg_;
......@@ -1301,6 +1307,7 @@ class Trace {
}
void InvalidateCurrentCharacter();
void AdvanceCurrentPositionInTrace(int by, RegExpCompiler* compiler);
private:
int FindAffectedRegisters(OutSet* affected_registers);
void PerformDeferredActions(RegExpMacroAssembler* macro,
......@@ -1402,6 +1409,7 @@ FOR_EACH_NODE_TYPE(DECLARE_VISIT)
void fail(const char* error_message) {
error_message_ = error_message;
}
private:
bool ignore_case_;
bool is_ascii_;
......
......@@ -49,7 +49,6 @@ namespace internal {
template <typename T, class P>
class List {
public:
List() { Initialize(0); }
INLINE(explicit List(int capacity)) { Initialize(capacity); }
INLINE(~List()) { DeleteData(data_); }
......
......@@ -114,7 +114,6 @@ class LiveObjectList {
static Object* PrintObj(int obj_id);
private:
struct Element {
int id_;
HeapObject* obj_;
......@@ -224,7 +223,6 @@ class LiveObjectList {
// Helper class for updating the LiveObjectList HeapObject pointers.
class UpdateLiveObjectListVisitor: public ObjectVisitor {
public:
void VisitPointer(Object** p) { UpdatePointer(p); }
void VisitPointers(Object** start, Object** end) {
......@@ -319,4 +317,3 @@ class LiveObjectList {
} } // namespace v8::internal
#endif // V8_LIVEOBJECTLIST_H_
......@@ -141,7 +141,6 @@ class LogMessageBuilder BASE_EMBEDDED {
void WriteToLogFile();
private:
Log* log_;
ScopedLock sl;
int pos_;
......
......@@ -1159,6 +1159,7 @@ class Assembler : public AssemblerBase {
}
return trampoline_slot;
}
private:
int start_;
int end_;
......
......@@ -118,6 +118,7 @@ class RegExpMacroAssemblerMIPS: public NativeRegExpMacroAssembler {
static int CheckStackGuardState(Address* return_address,
Code* re_code,
Address re_frame);
private:
// Offsets from frame_pointer() of function parameters and stored registers.
static const int kFramePointer = 0;
......
......@@ -3154,7 +3154,6 @@ class ByteArray: public FixedArrayBase {
// raised rather than being silently ignored.
class ExternalArray: public FixedArrayBase {
public:
inline bool is_the_hole(int index) { return false; }
// [external_pointer]: The pointer to the external memory area backing this
......@@ -6409,7 +6408,6 @@ class ConsString: public String {
// - truncating sliced string to enable otherwise unneeded parent to be GC'ed.
class SlicedString: public String {
public:
inline String* parent();
inline void set_parent(String* parent);
inline int offset();
......
......@@ -474,7 +474,6 @@ void Thread::YieldCPU() {
class CygwinMutex : public Mutex {
public:
CygwinMutex() {
pthread_mutexattr_t attrs;
memset(&attrs, 0, sizeof(attrs));
......
......@@ -471,7 +471,6 @@ void Thread::YieldCPU() {
class FreeBSDMutex : public Mutex {
public:
FreeBSDMutex() {
pthread_mutexattr_t attrs;
int result = pthread_mutexattr_init(&attrs);
......
......@@ -558,7 +558,6 @@ void Thread::YieldCPU() {
class MacOSMutex : public Mutex {
public:
MacOSMutex() {
pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr);
......
......@@ -460,7 +460,6 @@ void Thread::YieldCPU() {
class SolarisMutex : public Mutex {
public:
SolarisMutex() {
pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr);
......
......@@ -107,6 +107,7 @@ class RegExpMacroAssemblerIrregexp: public RegExpMacroAssembler {
virtual IrregexpImplementation Implementation();
virtual Handle<HeapObject> GetCode(Handle<String> source);
private:
void Expand();
// Code and bitmap emission.
......
......@@ -95,6 +95,7 @@ class RegExpMacroAssemblerTracer: public RegExpMacroAssembler {
virtual void WriteCurrentPositionToRegister(int reg, int cp_offset);
virtual void ClearRegisters(int reg_from, int reg_to);
virtual void WriteStackPointerToRegister(int reg);
private:
RegExpMacroAssembler* assembler_;
};
......
......@@ -89,6 +89,7 @@ class RegExpStack {
char* ArchiveStack(char* to);
char* RestoreStack(char* from);
void FreeThreadResources() { thread_local_.Free(); }
private:
RegExpStack();
~RegExpStack();
......
......@@ -135,7 +135,6 @@ class UnicodeCache {
bool IsWhiteSpace(unibrow::uchar c) { return kIsWhiteSpace.get(c); }
private:
unibrow::Predicate<IdentifierStart, 128> kIsIdentifierStart;
unibrow::Predicate<IdentifierPart, 128> kIsIdentifierPart;
unibrow::Predicate<unibrow::LineTerminator, 128> kIsLineTerminator;
......@@ -198,6 +197,7 @@ class LiteralBuffer {
position_ = 0;
is_ascii_ = true;
}
private:
static const int kInitialCapacity = 16;
static const int kGrowthFactory = 4;
......
......@@ -156,7 +156,6 @@ class SerializedScopeInfo : public FixedArray {
static SerializedScopeInfo* Empty();
private:
inline Object** ContextEntriesAddr();
inline Object** ParameterEntriesAddr();
......@@ -187,6 +186,7 @@ class ContextSlotCache {
void Clear();
static const int kNotFound = -2;
private:
ContextSlotCache() {
for (int i = 0; i < kLength; ++i) {
......
......@@ -1232,8 +1232,8 @@ class PagedSpace : public Space {
// Returns the number of total pages in this space.
int CountTotalPages();
#endif
private:
private:
// Returns a pointer to the page of the relocation pointer.
Page* MCRelocationTopPage() { return TopPageOf(mc_forwarding_info_); }
......@@ -1816,7 +1816,6 @@ class FixedSizeFreeList BASE_EMBEDDED {
void MarkNodes();
private:
Heap* heap_;
// Available bytes on the free list.
......
......@@ -123,8 +123,8 @@ class SplayTree {
Value value() { return value_; }
Node* left() { return left_; }
Node* right() { return right_; }
private:
private:
friend class SplayTree;
friend class Locator;
Key key_;
......@@ -143,6 +143,7 @@ class SplayTree {
Value& value() { return node_->value_; }
void set_value(const Value& value) { node_->value_ = value; }
inline void bind(Node* node) { node_ = node; }
private:
Node* node_;
};
......@@ -151,7 +152,6 @@ class SplayTree {
void ForEach(Callback* callback);
protected:
// Resets tree root. Existing nodes become unreachable.
void ResetRoot() { root_ = NULL; }
......@@ -187,7 +187,6 @@ class SplayTree {
void Call(Node* node) { delete node; }
private:
DISALLOW_COPY_AND_ASSIGN(NodeDeleter);
};
......
......@@ -93,6 +93,7 @@ class FmtElm {
FmtElm(void* value) : type_(POINTER) { // NOLINT
data_.u_pointer_ = value;
}
private:
friend class StringStream;
enum Type { INT, DOUBLE, C_STR, LC_STR, OBJ, HANDLE, POINTER };
......
......@@ -890,6 +890,7 @@ class SimpleStringBuilder {
int position_;
bool is_finalized() const { return position_ < 0; }
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(SimpleStringBuilder);
};
......
......@@ -54,6 +54,7 @@ class ThreadState {
// Get data area for archiving a thread.
char* data() { return data_; }
private:
explicit ThreadState(ThreadManager* thread_manager);
......
......@@ -453,6 +453,7 @@ class CpuFeatures : public AllStatic {
// Enable a specified feature within a scope.
class Scope BASE_EMBEDDED {
#ifdef DEBUG
public:
explicit Scope(CpuFeature f) {
uint64_t mask = V8_UINT64_C(1) << f;
......@@ -472,10 +473,12 @@ class CpuFeatures : public AllStatic {
isolate_->set_enabled_cpu_features(old_enabled_);
}
}
private:
Isolate* isolate_;
uint64_t old_enabled_;
#else
public:
explicit Scope(CpuFeature f) {}
#endif
......
......@@ -110,6 +110,7 @@ class ApiTestFuzzer: public v8::internal::Thread {
// This method switches threads if we are running the Threading test.
// Otherwise it does nothing.
static void Fuzz();
private:
static bool fuzzing_;
static int tests_being_run_;
......
......@@ -157,6 +157,7 @@ class DebugLocalContext {
Handle<Object>(debug->debug_context()->global_proxy()), DONT_ENUM,
::v8::internal::kNonStrictMode);
}
private:
v8::Persistent<v8::Context> context_;
};
......
......@@ -142,6 +142,7 @@ class JoinableThread {
}
virtual void Run() = 0;
private:
class ThreadWithSemaphore : public i::Thread {
public:
......@@ -377,6 +378,7 @@ class LockerUnlockerThread : public JoinableThread {
CalcFibAndCheck();
}
}
private:
v8::Isolate* isolate_;
};
......@@ -429,6 +431,7 @@ class LockTwiceAndUnlockThread : public JoinableThread {
CalcFibAndCheck();
}
}
private:
v8::Isolate* isolate_;
};
......@@ -498,6 +501,7 @@ class LockAndUnlockDifferentIsolatesThread : public JoinableThread {
thread.Join();
}
}
private:
v8::Isolate* isolate1_;
v8::Isolate* isolate2_;
......
......@@ -161,6 +161,7 @@ class ThreadIdValidationThread : public v8::internal::Thread {
}
semaphore_->Signal();
}
private:
i::List<i::ThreadId>* refs_;
int thread_no_;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment