Commit b8571b30 authored by Milad Fa's avatar Milad Fa Committed by V8 LUCI CQ

[sparkplug] remove UNREACHABLE from constexpr functions

gcc may throw the following compilation error if UNREACHABLE
is used within a constexpr function:
```
error: call to non-'constexpr' function
                  'void V8_Fatal(const char*, ...)'
```

Bug: v8:11420
Change-Id: I7f8237d00ba1a5d9bd778d45eb833b89cbe8eb24
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2906032
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74688}
parent 3d9d4745
...@@ -111,7 +111,6 @@ class Builtins { ...@@ -111,7 +111,6 @@ class Builtins {
case SaveFPRegsMode::kSave: case SaveFPRegsMode::kSave:
return Builtins::kEphemeronKeyBarrierSaveFP; return Builtins::kEphemeronKeyBarrierSaveFP;
} }
UNREACHABLE();
} }
// Convenience wrappers. // Convenience wrappers.
......
...@@ -169,7 +169,6 @@ class V8_EXPORT_PRIVATE WasmCode final { ...@@ -169,7 +169,6 @@ class V8_EXPORT_PRIVATE WasmCode final {
return RuntimeStubId::kRecordWriteOmitRememberedSetSaveFP; return RuntimeStubId::kRecordWriteOmitRememberedSetSaveFP;
} }
} }
UNREACHABLE();
} }
Vector<byte> instructions() const { Vector<byte> instructions() const {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment