Commit b72fe64e authored by Yutaka Hirano's avatar Yutaka Hirano Committed by Commit Bot

Remove Unused params from Compiler::GetFunctionFromEval

Bug: None
Change-Id: I26f136ff20f67b3eebc4374c9ac380d63f720ba9
Reviewed-on: https://chromium-review.googlesource.com/1192802
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55572}
parent 8d2241ca
...@@ -1196,9 +1196,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval( ...@@ -1196,9 +1196,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval(
Handle<String> source, Handle<SharedFunctionInfo> outer_info, Handle<String> source, Handle<SharedFunctionInfo> outer_info,
Handle<Context> context, LanguageMode language_mode, Handle<Context> context, LanguageMode language_mode,
ParseRestriction restriction, int parameters_end_pos, ParseRestriction restriction, int parameters_end_pos,
int eval_scope_position, int eval_position, int line_offset, int eval_scope_position, int eval_position) {
int column_offset, Handle<Object> script_name,
ScriptOriginOptions options) {
Isolate* isolate = context->GetIsolate(); Isolate* isolate = context->GetIsolate();
int source_length = source->length(); int source_length = source->length();
isolate->counters()->total_eval_size()->Increment(source_length); isolate->counters()->total_eval_size()->Increment(source_length);
...@@ -1237,14 +1235,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval( ...@@ -1237,14 +1235,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval(
allow_eval_cache = true; allow_eval_cache = true;
} else { } else {
ParseInfo parse_info(isolate); ParseInfo parse_info(isolate);
script = parse_info.CreateScript(isolate, source, options); script = parse_info.CreateScript(isolate, source, ScriptOriginOptions());
if (!script_name.is_null()) {
// TODO(cbruni): check whether we can store this data in options
script->set_name(*script_name);
script->set_line_offset(line_offset);
script->set_column_offset(column_offset);
LOG(isolate, ScriptDetails(*script));
}
script->set_compilation_type(Script::COMPILATION_TYPE_EVAL); script->set_compilation_type(Script::COMPILATION_TYPE_EVAL);
script->set_eval_from_shared(*outer_info); script->set_eval_from_shared(*outer_info);
if (eval_position == kNoSourcePosition) { if (eval_position == kNoSourcePosition) {
......
...@@ -101,9 +101,7 @@ class V8_EXPORT_PRIVATE Compiler : public AllStatic { ...@@ -101,9 +101,7 @@ class V8_EXPORT_PRIVATE Compiler : public AllStatic {
Handle<String> source, Handle<SharedFunctionInfo> outer_info, Handle<String> source, Handle<SharedFunctionInfo> outer_info,
Handle<Context> context, LanguageMode language_mode, Handle<Context> context, LanguageMode language_mode,
ParseRestriction restriction, int parameters_end_pos, ParseRestriction restriction, int parameters_end_pos,
int eval_scope_position, int eval_position, int line_offset = 0, int eval_scope_position, int eval_position);
int column_offset = 0, Handle<Object> script_name = Handle<Object>(),
ScriptOriginOptions options = ScriptOriginOptions());
struct ScriptDetails { struct ScriptDetails {
ScriptDetails() : line_offset(0), column_offset(0) {} ScriptDetails() : line_offset(0), column_offset(0) {}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment