Commit b6477a7f authored by Sathya Gunasekaran's avatar Sathya Gunasekaran Committed by Commit Bot

[WeakRefs] Fix FinalizationGroup.prototype.{register, cleanupSome}.length

Bug: v8:8179
Change-Id: I4db5412b5ed60aa100198628bfa09903c89a5c0d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710675Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62865}
parent 2c95484a
......@@ -4309,14 +4309,14 @@ void Genesis::InitializeGlobal_harmony_weak_refs() {
finalization_group_fun, DONT_ENUM);
SimpleInstallFunction(isolate(), finalization_group_prototype, "register",
Builtins::kFinalizationGroupRegister, 3, false);
Builtins::kFinalizationGroupRegister, 2, false);
SimpleInstallFunction(isolate(), finalization_group_prototype, "unregister",
Builtins::kFinalizationGroupUnregister, 1, false);
SimpleInstallFunction(isolate(), finalization_group_prototype,
"cleanupSome",
Builtins::kFinalizationGroupCleanupSome, 1, false);
Builtins::kFinalizationGroupCleanupSome, 0, false);
}
{
// Create %WeakRefPrototype%
......
......@@ -538,8 +538,6 @@
'built-ins/FinalizationGroup/gc-has-one-chance-to-call-cleanupCallback': [FAIL],
'built-ins/FinalizationGroup/newtarget-prototype-is-not-object': [FAIL],
'built-ins/FinalizationGroup/proto-from-ctor-realm': [FAIL],
'built-ins/FinalizationGroup/prototype/cleanupSome/length': [FAIL],
'built-ins/FinalizationGroup/prototype/register/length': [FAIL],
'built-ins/FinalizationGroup/prototype/register/return-undefined-register-itself': [FAIL],
'built-ins/FinalizationGroup/prototype/register/unregisterToken-not-object-or-undefined-throws': [FAIL],
'built-ins/FinalizationGroup/FinalizationGroupCleanupIteratorPrototype/next-job-not-active-throws': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment