Commit b5b9c2ca authored by Igor Sheludko's avatar Igor Sheludko Committed by V8 LUCI CQ

[cleanup] Remove unused TailCallOptimizedCodeSlot builtin

Bug: v8:11879
Change-Id: Ifb894d8beec6b54a9b7ff879dd4d6710306ba15b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960217
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75139}
parent 13209a75
......@@ -1777,14 +1777,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ Ret();
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
UseScratchRegisterScope temps(masm);
// Need a few extra registers
temps.Include(r8, r9);
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
TailCallOptimizedCodeSlot(masm, optimized_code_entry, temps.Acquire());
}
namespace {
void Generate_OSREntry(MacroAssembler* masm, Register entry_address,
......
......@@ -2023,12 +2023,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ Ret();
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
UseScratchRegisterScope temps(masm);
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
TailCallOptimizedCodeSlot(masm, optimized_code_entry, temps.AcquireX());
}
namespace {
void Generate_OSREntry(MacroAssembler* masm, Register entry_address,
......
......@@ -235,8 +235,6 @@ namespace internal {
/* Type conversions continuations */ \
TFC(ToBooleanLazyDeoptContinuation, SingleParameterOnStack) \
\
ASM(TailCallOptimizedCodeSlot, TailCallOptimizedCodeSlot) \
\
/* Handlers */ \
TFH(KeyedLoadIC_PolymorphicName, LoadWithVector) \
TFH(KeyedStoreIC_Megamorphic, Store) \
......
......@@ -1027,9 +1027,6 @@ void Builtins::Generate_BaselineLeaveFrame(MacroAssembler* masm) {
void Builtins::Generate_BaselineOnStackReplacement(MacroAssembler* masm) {
masm->Trap();
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
masm->Trap();
}
#endif
// ES6 [[Get]] operation.
......
......@@ -1878,10 +1878,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ ret(1 * kSystemPointerSize); // Remove eax.
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
TailCallOptimizedCodeSlot(masm, ecx);
}
// static
void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
// ----------- S t a t e -------------
......
......@@ -1749,11 +1749,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ Addu(sp, sp, Operand(1 * kPointerSize)); // Remove accumulator.
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
TailCallOptimizedCodeSlot(masm, optimized_code_entry, t7, t4);
}
namespace {
void Generate_OSREntry(MacroAssembler* masm, Register entry_address,
......
......@@ -1768,11 +1768,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ Daddu(sp, sp, Operand(1 * kPointerSize)); // Remove state.
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
TailCallOptimizedCodeSlot(masm, optimized_code_entry, t3, t0);
}
namespace {
void Generate_OSREntry(MacroAssembler* masm, Register entry_address,
......
......@@ -1838,13 +1838,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ Ret();
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
UseScratchRegisterScope temps(masm);
temps.Include(t4, t0);
TailCallOptimizedCodeSlot(masm, optimized_code_entry, temps.Acquire(),
temps.Acquire());
}
namespace {
void Generate_OSREntry(MacroAssembler* masm, Register entry_address,
......
......@@ -1858,14 +1858,6 @@ void Builtins::Generate_NotifyDeoptimized(MacroAssembler* masm) {
__ ret(1 * kSystemPointerSize); // Remove rax.
}
void Builtins::Generate_TailCallOptimizedCodeSlot(MacroAssembler* masm) {
Register optimized_code_entry = kJavaScriptCallCodeStartRegister;
Register closure = kJSFunctionRegister;
TailCallOptimizedCodeSlot(masm, optimized_code_entry, closure, r9,
WriteBarrierDescriptor::SlotAddressRegister(),
JumpMode::kJump);
}
// static
void Builtins::Generate_FunctionPrototypeApply(MacroAssembler* masm) {
// ----------- S t a t e -------------
......
......@@ -372,11 +372,6 @@ constexpr auto FastNewObjectDescriptor::registers() {
return RegisterArray(TargetRegister(), NewTargetRegister());
}
// static
constexpr auto TailCallOptimizedCodeSlotDescriptor::registers() {
return RegisterArray(kJavaScriptCallCodeStartRegister);
}
// static
constexpr auto LoadNoFeedbackDescriptor::registers() {
return RegisterArray(LoadDescriptor::ReceiverRegister(),
......
......@@ -77,7 +77,6 @@ namespace internal {
V(InterpreterCEntry1) \
V(InterpreterCEntry2) \
V(InterpreterDispatch) \
V(TailCallOptimizedCodeSlot) \
V(InterpreterPushArgsThenCall) \
V(InterpreterPushArgsThenConstruct) \
V(JSTrampoline) \
......@@ -1551,17 +1550,6 @@ class GrowArrayElementsDescriptor
static constexpr auto registers();
};
class V8_EXPORT_PRIVATE TailCallOptimizedCodeSlotDescriptor
: public StaticCallInterfaceDescriptor<
TailCallOptimizedCodeSlotDescriptor> {
public:
DEFINE_PARAMETERS(kOptimizedCodeEntry)
DEFINE_PARAMETER_TYPES(MachineType::AnyTagged()) // kAccumulator
DECLARE_DESCRIPTOR(TailCallOptimizedCodeSlotDescriptor)
static constexpr auto registers();
};
class BaselineOutOfLinePrologueDescriptor
: public StaticCallInterfaceDescriptor<
BaselineOutOfLinePrologueDescriptor> {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment