Commit b4666dbc authored by Manos Koukoutos's avatar Manos Koukoutos Committed by V8 LUCI CQ

[wasm][turbofan] Do not assert constants are untyped

See crrev.com/c/v8/v8/+/3660248 for context on typed wasm nodes.

Bug: chromium:1329939
Change-Id: I58ce7790e75fa1e228ae5ea6a84216889099a203
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676852
Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80821}
parent e4a8e0c4
......@@ -420,9 +420,17 @@ void Verifier::Visitor::Check(Node* node, const AllNodes& all) {
}
case IrOpcode::kInt32Constant: // TODO(turbofan): rename Word32Constant?
case IrOpcode::kInt64Constant: // TODO(turbofan): rename Word64Constant?
case IrOpcode::kTaggedIndexConstant:
case IrOpcode::kFloat32Constant:
case IrOpcode::kFloat64Constant:
case IrOpcode::kFloat64Constant: {
// Constants have no inputs.
CHECK_EQ(0, input_count);
// Wasm numeric constants have types. However, since wasm only gets
// verified in untyped mode, we do not need to check that the types match.
// TODO(manoskouk): Verify the type if wasm runs in typed mode.
if (code_type != kWasm) CheckNotTyped(node);
break;
}
case IrOpcode::kTaggedIndexConstant:
case IrOpcode::kRelocatableInt32Constant:
case IrOpcode::kRelocatableInt64Constant:
// Constants have no inputs.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment