Cleanup and fix generated comments in the top-level compiler.

 
Review URL: http://codereview.chromium.org/384087

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent ff3e8453
...@@ -123,7 +123,7 @@ void FastCodeGenerator::Generate(FunctionLiteral* fun) { ...@@ -123,7 +123,7 @@ void FastCodeGenerator::Generate(FunctionLiteral* fun) {
// Put the lr setup instruction in the delay slot. The kInstrSize is // Put the lr setup instruction in the delay slot. The kInstrSize is
// added to the implicit 8 byte offset that always applies to operations // added to the implicit 8 byte offset that always applies to operations
// with pc and gives a return address 12 bytes down. // with pc and gives a return address 12 bytes down.
Comment cmnt(masm_, "[ Stack check"); { Comment cmnt(masm_, "[ Stack check");
__ LoadRoot(r2, Heap::kStackLimitRootIndex); __ LoadRoot(r2, Heap::kStackLimitRootIndex);
__ add(lr, pc, Operand(Assembler::kInstrSize)); __ add(lr, pc, Operand(Assembler::kInstrSize));
__ cmp(sp, Operand(r2)); __ cmp(sp, Operand(r2));
...@@ -133,6 +133,7 @@ void FastCodeGenerator::Generate(FunctionLiteral* fun) { ...@@ -133,6 +133,7 @@ void FastCodeGenerator::Generate(FunctionLiteral* fun) {
RelocInfo::CODE_TARGET), RelocInfo::CODE_TARGET),
LeaveCC, LeaveCC,
lo); lo);
}
{ Comment cmnt(masm_, "[ Declarations"); { Comment cmnt(masm_, "[ Declarations");
VisitDeclarations(fun->scope()->declarations()); VisitDeclarations(fun->scope()->declarations());
...@@ -326,6 +327,7 @@ void FastCodeGenerator::TestAndBranch(Register source, ...@@ -326,6 +327,7 @@ void FastCodeGenerator::TestAndBranch(Register source,
void FastCodeGenerator::VisitDeclaration(Declaration* decl) { void FastCodeGenerator::VisitDeclaration(Declaration* decl) {
Comment cmnt(masm_, "[ Declaration");
Variable* var = decl->proxy()->var(); Variable* var = decl->proxy()->var();
ASSERT(var != NULL); // Must have been resolved. ASSERT(var != NULL); // Must have been resolved.
Slot* slot = var->slot(); Slot* slot = var->slot();
......
...@@ -76,7 +76,6 @@ int FastCodeGenerator::SlotOffset(Slot* slot) { ...@@ -76,7 +76,6 @@ int FastCodeGenerator::SlotOffset(Slot* slot) {
void FastCodeGenerator::VisitDeclarations( void FastCodeGenerator::VisitDeclarations(
ZoneList<Declaration*>* declarations) { ZoneList<Declaration*>* declarations) {
Comment cmnt(masm_, "[ Declarations");
int length = declarations->length(); int length = declarations->length();
int globals = 0; int globals = 0;
for (int i = 0; i < length; i++) { for (int i = 0; i < length; i++) {
......
...@@ -322,6 +322,7 @@ void FastCodeGenerator::TestAndBranch(Register source, ...@@ -322,6 +322,7 @@ void FastCodeGenerator::TestAndBranch(Register source,
void FastCodeGenerator::VisitDeclaration(Declaration* decl) { void FastCodeGenerator::VisitDeclaration(Declaration* decl) {
Comment cmnt(masm_, "[ Declaration");
Variable* var = decl->proxy()->var(); Variable* var = decl->proxy()->var();
ASSERT(var != NULL); // Must have been resolved. ASSERT(var != NULL); // Must have been resolved.
Slot* slot = var->slot(); Slot* slot = var->slot();
......
...@@ -336,6 +336,7 @@ void FastCodeGenerator::TestAndBranch(Register source, ...@@ -336,6 +336,7 @@ void FastCodeGenerator::TestAndBranch(Register source,
void FastCodeGenerator::VisitDeclaration(Declaration* decl) { void FastCodeGenerator::VisitDeclaration(Declaration* decl) {
Comment cmnt(masm_, "[ Declaration");
Variable* var = decl->proxy()->var(); Variable* var = decl->proxy()->var();
ASSERT(var != NULL); // Must have been resolved. ASSERT(var != NULL); // Must have been resolved.
Slot* slot = var->slot(); Slot* slot = var->slot();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment