Commit b21bc232 authored by Jochen Eisinger's avatar Jochen Eisinger Committed by Commit Bot

Add layout test bots to changes to api.cc

Also restrict include/ rules to only add bots for changes affecting
headers

R=machenbach@chromium.org

Change-Id: I97dc3c6249994566912a82ac9fbf8c7d3a57890c
Reviewed-on: https://chromium-review.googlesource.com/519342Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45638}
parent 6a65e6de
...@@ -8,7 +8,7 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts ...@@ -8,7 +8,7 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools. for more details about the presubmit API built into depot_tools.
""" """
import re import os
def PostUploadHook(cl, change, output_api): def PostUploadHook(cl, change, output_api):
...@@ -17,6 +17,10 @@ def PostUploadHook(cl, change, output_api): ...@@ -17,6 +17,10 @@ def PostUploadHook(cl, change, output_api):
This hook adds extra try bots to the CL description in order to run layout This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots. tests in addition to CQ try bots.
""" """
def header_filter(f):
return '.h' in os.path.split(f.LocalPath())[1]
if not change.AffectedFiles(file_filter=header_filter):
return []
return output_api.EnsureCQIncludeTrybotsAreAdded( return output_api.EnsureCQIncludeTrybotsAreAdded(
cl, cl,
[ [
......
# Copyright 2017 the V8 project authors. All rights reserved.')
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for //v8/src
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
"""
import os
def PostUploadHook(cl, change, output_api):
"""git cl upload will call this hook after the issue is created/modified.
This hook adds extra try bots to the CL description in order to run layout
tests in addition to CQ try bots.
"""
def is_api_cc(f):
return 'api.cc' == os.path.split(f.LocalPath())[1]
if not change.AffectedFiles(file_filter=is_api_cc):
return []
return output_api.EnsureCQIncludeTrybotsAreAdded(
cl,
[
'master.tryserver.chromium.linux:linux_chromium_rel_ng'
],
'Automatically added layout test trybots to run tests on CQ.')
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment