[Fix] Allow LazyInstance to support classes with virtual members

Change the signature of `Construct` so that no casting is required on
calling it. The casting would fire control flow integrity check if the
class contains virtual members.

Bug: chromium:758925
Change-Id: Iefc711c634b36efd051e245e2df13b28d5563f45
Reviewed-on: https://chromium-review.googlesource.com/635563Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Albert Mingkun Yang <albertnetymk@google.com>
Cr-Commit-Position: refs/heads/master@{#47608}

src/assert-scope.cc

@@ -15,7 +15,8 @@ namespace internal {
 namespace {
 
 struct PerThreadAssertKeyConstructTrait final {
-  static void Construct(base::Thread::LocalStorageKey* key) {
+  static void Construct(void* key_arg) {
+    auto key = reinterpret_cast<base::Thread::LocalStorageKey*>(key_arg);
     *key = base::Thread::CreateThreadLocalKey();
   }
 };

src/base/lazy-instance.h

@@ -35,7 +35,7 @@
 // providing your own trait:
 // Example usage:
 //   struct MyCreateTrait {
-//     static void Construct(MyClass* allocated_ptr) {
+//     static void Construct(void* allocated_ptr) {
 //       new (allocated_ptr) MyClass(/* extra parameters... */);
 //     }
 //   };
@@ -105,7 +105,7 @@ struct StaticallyAllocatedInstanceTrait {
 
   template <typename ConstructTrait>
   static void InitStorageUsingTrait(StorageType* storage) {
-    ConstructTrait::Construct(MutableInstance(storage));
+    ConstructTrait::Construct(storage);
   }
 };
 
@@ -128,9 +128,7 @@ struct DynamicallyAllocatedInstanceTrait {
 template <typename T>
 struct DefaultConstructTrait {
   // Constructs the provided object which was already allocated.
-  static void Construct(T* allocated_ptr) {
-    new(allocated_ptr) T();
-  }
+  static void Construct(void* allocated_ptr) { new (allocated_ptr) T(); }
 };
 
 

src/elements-kind.cc

@@ -66,8 +66,9 @@ const char* ElementsKindToString(ElementsKind kind) {
 
 
 struct InitializeFastElementsKindSequence {
-  static void Construct(
-      ElementsKind** fast_elements_kind_sequence_ptr) {
+  static void Construct(void* fast_elements_kind_sequence_ptr_arg) {
+    auto fast_elements_kind_sequence_ptr =
+        reinterpret_cast<ElementsKind**>(fast_elements_kind_sequence_ptr_arg);
     ElementsKind* fast_elements_kind_sequence =
         new ElementsKind[kFastElementsKindCount];
     *fast_elements_kind_sequence_ptr = fast_elements_kind_sequence;

src/register-configuration.cc

@@ -136,7 +136,7 @@ class ArchDefaultRegisterConfiguration : public RegisterConfiguration {
 };
 
 struct RegisterConfigurationInitializer {
-  static void Construct(ArchDefaultRegisterConfiguration* config) {
+  static void Construct(void* config) {
     new (config) ArchDefaultRegisterConfiguration();
   }
 };