Commit b1f64610 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

api: Advance forward deprecations in EmbedderHeapTracer

Change-Id: Iea75626e58d60506ff54c2ab2b6ee814230fb80c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1768580
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63368}
parent 604b0e1e
......@@ -7378,7 +7378,7 @@ class V8_EXPORT EmbedderHeapTracer {
/**
* Called at the beginning of a GC cycle.
*/
V8_DEPRECATE_SOON("Use version with flags.", virtual void TracePrologue()) {}
V8_DEPRECATED("Use version with flags.", virtual void TracePrologue()) {}
virtual void TracePrologue(TraceFlags flags);
/**
......@@ -7406,8 +7406,9 @@ class V8_EXPORT EmbedderHeapTracer {
* overriden to fill a |TraceSummary| that is used by V8 to schedule future
* garbage collections.
*/
virtual void TraceEpilogue() {}
virtual void TraceEpilogue(TraceSummary* trace_summary) { TraceEpilogue(); }
V8_DEPRECATE_SOON("Use version with parameter.",
virtual void TraceEpilogue()) {}
virtual void TraceEpilogue(TraceSummary* trace_summary);
/**
* Called upon entering the final marking pause. No more incremental marking
......
......@@ -10274,6 +10274,17 @@ void EmbedderHeapTracer::TracePrologue(TraceFlags flags) {
#endif
}
void EmbedderHeapTracer::TraceEpilogue(TraceSummary* trace_summary) {
#if __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated"
#endif
TraceEpilogue();
#if __clang__
#pragma clang diagnostic pop
#endif
}
void EmbedderHeapTracer::FinalizeTracing() {
if (isolate_) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment