Use new.target in favor of %_IsConstructCall intrinsic (1).

This switches several builtin methods to use the ES6 new.target value
when determined whether being called as a constructor or not. This is
prepatory work for fully deprecating the aforementioned intrinsic.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/1477073005

Cr-Commit-Position: refs/heads/master@{#32397}

src/js/collection.js

@@ -125,7 +125,7 @@ function GetHash(key) {
 // Harmony Set
 
 function SetConstructor(iterable) {
-  if (!%_IsConstructCall()) {
+  if (IS_UNDEFINED(new.target)) {
     throw MakeTypeError(kConstructorNotFunction, "Set");
   }
 
@@ -281,7 +281,7 @@ utils.InstallFunctions(GlobalSet.prototype, DONT_ENUM, [
 // Harmony Map
 
 function MapConstructor(iterable) {
-  if (!%_IsConstructCall()) {
+  if (IS_UNDEFINED(new.target)) {
     throw MakeTypeError(kConstructorNotFunction, "Map");
   }
 

src/js/harmony-sharedarraybuffer.js

@@ -22,7 +22,7 @@ utils.Import(function(from) {
 // -------------------------------------------------------------------
 
 function SharedArrayBufferConstructor(length) { // length = 1
-  if (%_IsConstructCall()) {
+  if (!IS_UNDEFINED(new.target)) {
     var byteLength = ToPositiveInteger(length, kInvalidArrayBufferLength);
     %ArrayBufferInitialize(this, byteLength, kShared);
   } else {

src/js/harmony-simd.js

@@ -433,34 +433,44 @@ SIMD_X16_TYPES(DECLARE_X16_FUNCTIONS)
 //-------------------------------------------------------------------
 
 function Float32x4Constructor(c0, c1, c2, c3) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Float32x4");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Float32x4");
+  }
   return %CreateFloat32x4(TO_NUMBER(c0), TO_NUMBER(c1),
                           TO_NUMBER(c2), TO_NUMBER(c3));
 }
 
 
 function Int32x4Constructor(c0, c1, c2, c3) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Int32x4");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Int32x4");
+  }
   return %CreateInt32x4(TO_NUMBER(c0), TO_NUMBER(c1),
                         TO_NUMBER(c2), TO_NUMBER(c3));
 }
 
 
 function Uint32x4Constructor(c0, c1, c2, c3) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Uint32x4");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Uint32x4");
+  }
   return %CreateUint32x4(TO_NUMBER(c0), TO_NUMBER(c1),
                          TO_NUMBER(c2), TO_NUMBER(c3));
 }
 
 
 function Bool32x4Constructor(c0, c1, c2, c3) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Bool32x4");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Bool32x4");
+  }
   return %CreateBool32x4(c0, c1, c2, c3);
 }
 
 
 function Int16x8Constructor(c0, c1, c2, c3, c4, c5, c6, c7) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Int16x8");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Int16x8");
+  }
   return %CreateInt16x8(TO_NUMBER(c0), TO_NUMBER(c1),
                         TO_NUMBER(c2), TO_NUMBER(c3),
                         TO_NUMBER(c4), TO_NUMBER(c5),
@@ -469,7 +479,9 @@ function Int16x8Constructor(c0, c1, c2, c3, c4, c5, c6, c7) {
 
 
 function Uint16x8Constructor(c0, c1, c2, c3, c4, c5, c6, c7) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Uint16x8");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Uint16x8");
+  }
   return %CreateUint16x8(TO_NUMBER(c0), TO_NUMBER(c1),
                          TO_NUMBER(c2), TO_NUMBER(c3),
                          TO_NUMBER(c4), TO_NUMBER(c5),
@@ -478,14 +490,18 @@ function Uint16x8Constructor(c0, c1, c2, c3, c4, c5, c6, c7) {
 
 
 function Bool16x8Constructor(c0, c1, c2, c3, c4, c5, c6, c7) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Bool16x8");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Bool16x8");
+  }
   return %CreateBool16x8(c0, c1, c2, c3, c4, c5, c6, c7);
 }
 
 
 function Int8x16Constructor(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11,
                             c12, c13, c14, c15) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Int8x16");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Int8x16");
+  }
   return %CreateInt8x16(TO_NUMBER(c0), TO_NUMBER(c1),
                         TO_NUMBER(c2), TO_NUMBER(c3),
                         TO_NUMBER(c4), TO_NUMBER(c5),
@@ -499,7 +515,9 @@ function Int8x16Constructor(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11,
 
 function Uint8x16Constructor(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11,
                              c12, c13, c14, c15) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Uint8x16");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Uint8x16");
+  }
   return %CreateUint8x16(TO_NUMBER(c0), TO_NUMBER(c1),
                          TO_NUMBER(c2), TO_NUMBER(c3),
                          TO_NUMBER(c4), TO_NUMBER(c5),
@@ -513,7 +531,9 @@ function Uint8x16Constructor(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11,
 
 function Bool8x16Constructor(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11,
                              c12, c13, c14, c15) {
-  if (%_IsConstructCall()) throw MakeTypeError(kNotConstructor, "Bool8x16");
+  if (!IS_UNDEFINED(new.target)) {
+    throw MakeTypeError(kNotConstructor, "Bool8x16");
+  }
   return %CreateBool8x16(c0, c1, c2, c3, c4, c5, c6, c7, c8, c9, c10, c11, c12,
                          c13, c14, c15);
 }

src/js/messages.js

@@ -937,7 +937,7 @@ function DefineError(global, f) {
   %AddNamedProperty(f.prototype, 'constructor', f, DONT_ENUM);
   %AddNamedProperty(f.prototype, 'name', name, DONT_ENUM);
   %SetCode(f, function(m) {
-    if (%_IsConstructCall()) {
+    if (!IS_UNDEFINED(new.target)) {
       try { captureStackTrace(this, f); } catch (e) { }
       // Define all the expected properties directly on the error
       // object. This avoids going through getters and setters defined

src/js/proxy.js

@@ -25,7 +25,7 @@ utils.Import(function(from) {
 //----------------------------------------------------------------------------
 
 function ProxyCreate(target, handler) {
-  if (!%_IsConstructCall()) {
+  if (IS_UNDEFINED(new.target)) {
     throw MakeTypeError(kConstructorNotFunction, "Proxy");
   }
   return %CreateJSProxy(target, handler);
@@ -66,7 +66,7 @@ function DerivedConstructTrap(callTrap) {
 
 function DelegateCallAndConstruct(callTrap, constructTrap) {
   return function() {
-    return %Apply(%_IsConstructCall() ? constructTrap : callTrap,
+    return %Apply(IS_UNDEFINED(new.target) ? callTrap : constructTrap,
                   this, arguments, 0, %_ArgumentsLength())
   }
 }

src/js/weak-collection.js

@@ -29,7 +29,7 @@ utils.Import(function(from) {
 // Harmony WeakMap
 
 function WeakMapConstructor(iterable) {
-  if (!%_IsConstructCall()) {
+  if (IS_UNDEFINED(new.target)) {
     throw MakeTypeError(kConstructorNotFunction, "WeakMap");
   }
 
@@ -118,7 +118,7 @@ utils.InstallFunctions(GlobalWeakMap.prototype, DONT_ENUM, [
 // Harmony WeakSet
 
 function WeakSetConstructor(iterable) {
-  if (!%_IsConstructCall()) {
+  if (IS_UNDEFINED(new.target)) {
     throw MakeTypeError(kConstructorNotFunction, "WeakSet");
   }