[interpreter] Be explicit when to test BytecodeGraphBuilder.

This adds a dedicated flag for enabling the BytecodeGraphBuilder. The
intention is to be explicit when this variant is being tested and to
avoid unnecessary overhead in production code for a configuration that
is not yet shipping.

R=rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/1925123002
Cr-Commit-Position: refs/heads/master@{#35892}

src/compiler.cc

@@ -839,7 +839,8 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
                    : new HCompilationJob(info.get()));
 
   // TruboFan can optimize directly from existing bytecode.
-  if (use_turbofan && info->shared_info()->HasBytecodeArray()) {
+  if (FLAG_turbo_from_bytecode && use_turbofan &&
+      info->shared_info()->HasBytecodeArray()) {
     info->MarkAsOptimizeFromBytecode();
   }
 

src/flag-definitions.h

@@ -409,6 +409,7 @@ DEFINE_BOOL(omit_map_checks_for_leaf_maps, true,
 DEFINE_BOOL(turbo, false, "enable TurboFan compiler")
 DEFINE_IMPLICATION(turbo, turbo_asm_deoptimization)
 DEFINE_BOOL(turbo_shipping, true, "enable TurboFan compiler on subset")
+DEFINE_BOOL(turbo_from_bytecode, false, "enable building graphs from bytecode")
 DEFINE_BOOL(turbo_greedy_regalloc, false, "use the greedy register allocator")
 DEFINE_BOOL(turbo_sp_frame_access, false,
             "use stack pointer-relative access to frame wherever possible")

test/cctest/compiler/function-tester.h

@@ -188,7 +188,7 @@ class FunctionTester : public InitializedHandleScope {
     if (flags_ & CompilationInfo::kInliningEnabled) {
       info.MarkAsInliningEnabled();
     }
-    if (function->shared()->HasBytecodeArray()) {
+    if (FLAG_turbo_from_bytecode && function->shared()->HasBytecodeArray()) {
       info.MarkAsOptimizeFromBytecode();
     } else {
       CHECK(Compiler::Analyze(info.parse_info()));

test/mjsunit/mjsunit.status

@@ -152,6 +152,9 @@
   # TODO(turbofan): The escape analysis needs some investigation.
   'compiler/escape-analysis-*': [PASS, NO_VARIANTS],
 
+  # TODO(mstarzinger): Fails in --turbo --always-opt mode.
+  'ignition/ignition-statistics-extension': [PASS, NO_VARIANTS],
+
   ##############################################################################
   # Too slow in debug mode with --stress-opt mode.
   'compiler/regress-stacktrace-methods': [PASS, ['mode == debug', SKIP]],

tools/testrunner/local/testsuite.py

@@ -42,7 +42,7 @@ ALL_VARIANT_FLAGS = {
   "turbofan_opt": [["--turbo", "--always-opt"]],
   "nocrankshaft": [["--nocrankshaft"]],
   "ignition": [["--ignition", "--turbo"]],
-  "ignition_turbofan": [["--ignition", "--turbo"]],
+  "ignition_turbofan": [["--ignition", "--turbo", "--turbo-from-bytecode"]],
   "preparser": [["--min-preparse-length=0"]],
 }
 
@@ -53,7 +53,7 @@ FAST_VARIANT_FLAGS = {
   "turbofan": [["--turbo"]],
   "nocrankshaft": [["--nocrankshaft"]],
   "ignition": [["--ignition", "--turbo"]],
-  "ignition_turbofan": [["--ignition", "--turbo"]],
+  "ignition_turbofan": [["--ignition", "--turbo", "--turbo-from-bytecode"]],
   "preparser": [["--min-preparse-length=0"]],
 }