Commit afd26925 authored by Philip Pfaffe's avatar Philip Pfaffe Committed by Commit Bot

Add more index spaces to the WebAssembly JS debug proxy

This CL adds the globals index space to the JS debug proxy as well as the
stack object. It also adds few small helpers to simplify the proxy setup
a little, since all index spaces work exaclty the same.

Bug: chromium:1127914
Change-Id: I707292ab7f44aafb73751c17fdacfef976316f39
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2448468
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70332}
parent 82cb91c2
This diff is collapsed.
...@@ -536,12 +536,12 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) { ...@@ -536,12 +536,12 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) {
Handle<String> snippet = Handle<String> snippet =
V8String(isolate, V8String(isolate,
"JSON.stringify([" "JSON.stringify(["
//"$global0, " "$global0, "
//"$table0, " //"$table0, "
"$var0, " "$var0, "
//"$main, " //"$main, "
//"$memory0, " //"$memory0, "
//"globals[0], " "globals[0], "
//"tables[0], " //"tables[0], "
"locals[0], " "locals[0], "
//"functions[0], " //"functions[0], "
...@@ -551,7 +551,7 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) { ...@@ -551,7 +551,7 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) {
//"stack, " //"stack, "
//"imports, " //"imports, "
//"exports, " //"exports, "
//"globals, " "globals, "
"locals, " "locals, "
//"functions, " //"functions, "
"], (k, v) => k === 'at' || typeof v === 'undefined' || typeof " "], (k, v) => k === 'at' || typeof v === 'undefined' || typeof "
...@@ -563,7 +563,7 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) { ...@@ -563,7 +563,7 @@ WASM_COMPILED_EXEC_TEST(WasmDebugEvaluate_JavaScript) {
WasmJSBreakHandler::EvaluationResult result = WasmJSBreakHandler::EvaluationResult result =
break_handler.result().ToChecked(); break_handler.result().ToChecked();
CHECK_WITH_MSG(result.error.IsNothing(), result.error.ToChecked().c_str()); CHECK_WITH_MSG(result.error.IsNothing(), result.error.ToChecked().c_str());
CHECK_EQ(result.result.ToChecked(), "[\"65\",\"65\",{}]"); CHECK_EQ(result.result.ToChecked(), "[\"66\",\"65\",\"66\",\"65\",{},{}]");
//"[\"66\",{},\"65\",\"function 0() { [native code] }\",{}," //"[\"66\",{},\"65\",\"function 0() { [native code] }\",{},"
//"\"66\",{},\"65\",\"function 0() { [native code] }\",{}," //"\"66\",{},\"65\",\"function 0() { [native code] }\",{},"
//"{},{},{\"0\":\"65\"},{},{},{},{},{}]"); //"{},{},{\"0\":\"65\"},{},{},{},{},{}]");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment