Add a few missing overrides found by a new clang warning.

Namely, -Winconsistent-missing-override. No behavior change.

BUG=v8:3658
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/688533002

Cr-Commit-Position: refs/heads/master@{#24994}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24994 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent dde9dff2
...@@ -24,12 +24,12 @@ class AstNumberingVisitor FINAL : public AstVisitor { ...@@ -24,12 +24,12 @@ class AstNumberingVisitor FINAL : public AstVisitor {
private: private:
// AST node visitor interface. // AST node visitor interface.
#define DEFINE_VISIT(type) virtual void Visit##type(type* node); #define DEFINE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
AST_NODE_LIST(DEFINE_VISIT) AST_NODE_LIST(DEFINE_VISIT)
#undef DEFINE_VISIT #undef DEFINE_VISIT
void VisitStatements(ZoneList<Statement*>* statements); void VisitStatements(ZoneList<Statement*>* statements) OVERRIDE;
void VisitDeclarations(ZoneList<Declaration*>* declarations); void VisitDeclarations(ZoneList<Declaration*>* declarations) OVERRIDE;
void VisitArguments(ZoneList<Expression*>* arguments); void VisitArguments(ZoneList<Expression*>* arguments);
void VisitObjectLiteralProperty(ObjectLiteralProperty* property); void VisitObjectLiteralProperty(ObjectLiteralProperty* property);
......
...@@ -941,10 +941,10 @@ class ForInStatement FINAL : public ForEachStatement { ...@@ -941,10 +941,10 @@ class ForInStatement FINAL : public ForEachStatement {
} }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(1, 0); return FeedbackVectorRequirements(1, 0);
} }
virtual void SetFirstFeedbackSlot(FeedbackVectorSlot slot) { virtual void SetFirstFeedbackSlot(FeedbackVectorSlot slot) OVERRIDE {
for_in_feedback_slot_ = slot; for_in_feedback_slot_ = slot;
} }
...@@ -1710,10 +1710,10 @@ class VariableProxy FINAL : public Expression { ...@@ -1710,10 +1710,10 @@ class VariableProxy FINAL : public Expression {
// Bind this proxy to the variable var. Interfaces must match. // Bind this proxy to the variable var. Interfaces must match.
void BindTo(Variable* var); void BindTo(Variable* var);
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0); return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0);
} }
virtual void SetFirstICFeedbackSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
variable_feedback_slot_ = slot; variable_feedback_slot_ = slot;
} }
...@@ -1764,7 +1764,7 @@ class Property FINAL : public Expression { ...@@ -1764,7 +1764,7 @@ class Property FINAL : public Expression {
virtual KeyedAccessStoreMode GetStoreMode() OVERRIDE { virtual KeyedAccessStoreMode GetStoreMode() OVERRIDE {
return STANDARD_STORE; return STANDARD_STORE;
} }
virtual IcCheckType GetKeyType() { virtual IcCheckType GetKeyType() OVERRIDE {
// PROPERTY key types currently aren't implemented for KeyedLoadICs. // PROPERTY key types currently aren't implemented for KeyedLoadICs.
return ELEMENT; return ELEMENT;
} }
...@@ -1781,10 +1781,10 @@ class Property FINAL : public Expression { ...@@ -1781,10 +1781,10 @@ class Property FINAL : public Expression {
return obj()->IsSuperReference(); return obj()->IsSuperReference();
} }
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0); return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0);
} }
virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
property_feedback_slot_ = slot; property_feedback_slot_ = slot;
} }
...@@ -1824,10 +1824,10 @@ class Call FINAL : public Expression { ...@@ -1824,10 +1824,10 @@ class Call FINAL : public Expression {
ZoneList<Expression*>* arguments() const { return arguments_; } ZoneList<Expression*>* arguments() const { return arguments_; }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(0, 1); return FeedbackVectorRequirements(0, 1);
} }
virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
call_feedback_slot_ = slot; call_feedback_slot_ = slot;
} }
...@@ -1924,10 +1924,10 @@ class CallNew FINAL : public Expression { ...@@ -1924,10 +1924,10 @@ class CallNew FINAL : public Expression {
ZoneList<Expression*>* arguments() const { return arguments_; } ZoneList<Expression*>* arguments() const { return arguments_; }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(FLAG_pretenuring_call_new ? 2 : 1, 0); return FeedbackVectorRequirements(FLAG_pretenuring_call_new ? 2 : 1, 0);
} }
virtual void SetFirstFeedbackSlot(FeedbackVectorSlot slot) { virtual void SetFirstFeedbackSlot(FeedbackVectorSlot slot) OVERRIDE {
callnew_feedback_slot_ = slot; callnew_feedback_slot_ = slot;
} }
...@@ -1986,11 +1986,11 @@ class CallRuntime FINAL : public Expression { ...@@ -1986,11 +1986,11 @@ class CallRuntime FINAL : public Expression {
bool is_jsruntime() const { return function_ == NULL; } bool is_jsruntime() const { return function_ == NULL; }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements( return FeedbackVectorRequirements(
0, (FLAG_vector_ics && is_jsruntime()) ? 1 : 0); 0, (FLAG_vector_ics && is_jsruntime()) ? 1 : 0);
} }
virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
callruntime_feedback_slot_ = slot; callruntime_feedback_slot_ = slot;
} }
...@@ -2347,11 +2347,11 @@ class Yield FINAL : public Expression { ...@@ -2347,11 +2347,11 @@ class Yield FINAL : public Expression {
} }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements( return FeedbackVectorRequirements(
0, (FLAG_vector_ics && yield_kind() == kDelegating) ? 3 : 0); 0, (FLAG_vector_ics && yield_kind() == kDelegating) ? 3 : 0);
} }
virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
yield_first_feedback_slot_ = slot; yield_first_feedback_slot_ = slot;
} }
...@@ -2667,10 +2667,10 @@ class SuperReference FINAL : public Expression { ...@@ -2667,10 +2667,10 @@ class SuperReference FINAL : public Expression {
TypeFeedbackId HomeObjectFeedbackId() { return TypeFeedbackId(local_id(0)); } TypeFeedbackId HomeObjectFeedbackId() { return TypeFeedbackId(local_id(0)); }
// Type feedback information. // Type feedback information.
virtual FeedbackVectorRequirements ComputeFeedbackRequirements() { virtual FeedbackVectorRequirements ComputeFeedbackRequirements() OVERRIDE {
return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0); return FeedbackVectorRequirements(0, FLAG_vector_ics ? 1 : 0);
} }
virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) { virtual void SetFirstFeedbackICSlot(FeedbackVectorICSlot slot) OVERRIDE {
homeobject_feedback_slot_ = slot; homeobject_feedback_slot_ = slot;
} }
......
This diff is collapsed.
...@@ -56,7 +56,7 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor { ...@@ -56,7 +56,7 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor {
// Support for control flow builders. The concrete type of the environment // Support for control flow builders. The concrete type of the environment
// depends on the graph builder, but environments themselves are not virtual. // depends on the graph builder, but environments themselves are not virtual.
typedef StructuredGraphBuilder::Environment BaseEnvironment; typedef StructuredGraphBuilder::Environment BaseEnvironment;
virtual BaseEnvironment* CopyEnvironment(BaseEnvironment* env); virtual BaseEnvironment* CopyEnvironment(BaseEnvironment* env) OVERRIDE;
// TODO(mstarzinger): The pipeline only needs to be a friend to access the // TODO(mstarzinger): The pipeline only needs to be a friend to access the
// function context. Remove as soon as the context is a parameter. // function context. Remove as soon as the context is a parameter.
...@@ -110,13 +110,13 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor { ...@@ -110,13 +110,13 @@ class AstGraphBuilder : public StructuredGraphBuilder, public AstVisitor {
// Builder for stack-check guards. // Builder for stack-check guards.
Node* BuildStackCheck(); Node* BuildStackCheck();
#define DECLARE_VISIT(type) virtual void Visit##type(type* node); #define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
// Visiting functions for AST nodes make this an AstVisitor. // Visiting functions for AST nodes make this an AstVisitor.
AST_NODE_LIST(DECLARE_VISIT) AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT #undef DECLARE_VISIT
// Visiting function for declarations list is overridden. // Visiting function for declarations list is overridden.
virtual void VisitDeclarations(ZoneList<Declaration*>* declarations); virtual void VisitDeclarations(ZoneList<Declaration*>* declarations) OVERRIDE;
private: private:
CompilationInfo* info_; CompilationInfo* info_;
......
...@@ -40,7 +40,7 @@ class BreakableStatementChecker: public AstVisitor { ...@@ -40,7 +40,7 @@ class BreakableStatementChecker: public AstVisitor {
private: private:
// AST node visit functions. // AST node visit functions.
#define DECLARE_VISIT(type) virtual void Visit##type(type* node); #define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
AST_NODE_LIST(DECLARE_VISIT) AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT #undef DECLARE_VISIT
...@@ -392,7 +392,7 @@ class FullCodeGenerator: public AstVisitor { ...@@ -392,7 +392,7 @@ class FullCodeGenerator: public AstVisitor {
void VisitInDuplicateContext(Expression* expr); void VisitInDuplicateContext(Expression* expr);
void VisitDeclarations(ZoneList<Declaration*>* declarations); void VisitDeclarations(ZoneList<Declaration*>* declarations) OVERRIDE;
void DeclareModules(Handle<FixedArray> descriptions); void DeclareModules(Handle<FixedArray> descriptions);
void DeclareGlobals(Handle<FixedArray> pairs); void DeclareGlobals(Handle<FixedArray> pairs);
int DeclareGlobalsFlags(); int DeclareGlobalsFlags();
...@@ -670,7 +670,7 @@ class FullCodeGenerator: public AstVisitor { ...@@ -670,7 +670,7 @@ class FullCodeGenerator: public AstVisitor {
void PushFunctionArgumentForContextAllocation(); void PushFunctionArgumentForContextAllocation();
// AST node visit functions. // AST node visit functions.
#define DECLARE_VISIT(type) virtual void Visit##type(type* node); #define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
AST_NODE_LIST(DECLARE_VISIT) AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT #undef DECLARE_VISIT
......
...@@ -1512,7 +1512,7 @@ class HCompareMap FINAL : public HUnaryControlInstruction { ...@@ -1512,7 +1512,7 @@ class HCompareMap FINAL : public HUnaryControlInstruction {
DECLARE_CONCRETE_INSTRUCTION(CompareMap) DECLARE_CONCRETE_INSTRUCTION(CompareMap)
protected: protected:
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
HCompareMap(HValue* value, HCompareMap(HValue* value,
...@@ -2800,7 +2800,7 @@ class HCheckMaps FINAL : public HTemplateInstruction<2> { ...@@ -2800,7 +2800,7 @@ class HCheckMaps FINAL : public HTemplateInstruction<2> {
return this->maps()->Equals(HCheckMaps::cast(other)->maps()); return this->maps()->Equals(HCheckMaps::cast(other)->maps());
} }
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
HCheckMaps(HValue* value, const UniqueSet<Map>* maps, bool maps_are_stable) HCheckMaps(HValue* value, const UniqueSet<Map>* maps, bool maps_are_stable)
...@@ -2952,7 +2952,7 @@ class HCheckInstanceType FINAL : public HUnaryOperation { ...@@ -2952,7 +2952,7 @@ class HCheckInstanceType FINAL : public HUnaryOperation {
return check_ == b->check_; return check_ == b->check_;
} }
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
const char* GetCheckName() const; const char* GetCheckName() const;
...@@ -4175,7 +4175,8 @@ class HBitwiseBinaryOperation : public HBinaryOperation { ...@@ -4175,7 +4175,8 @@ class HBitwiseBinaryOperation : public HBinaryOperation {
return r; return r;
} }
virtual void initialize_output_representation(Representation observed) { virtual void initialize_output_representation(
Representation observed) OVERRIDE {
if (observed.IsDouble()) observed = Representation::Integer32(); if (observed.IsDouble()) observed = Representation::Integer32();
HBinaryOperation::initialize_output_representation(observed); HBinaryOperation::initialize_output_representation(observed);
} }
...@@ -4474,7 +4475,7 @@ class HIsStringAndBranch FINAL : public HUnaryControlInstruction { ...@@ -4474,7 +4475,7 @@ class HIsStringAndBranch FINAL : public HUnaryControlInstruction {
DECLARE_CONCRETE_INSTRUCTION(IsStringAndBranch) DECLARE_CONCRETE_INSTRUCTION(IsStringAndBranch)
protected: protected:
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
HIsStringAndBranch(HValue* value, HBasicBlock* true_target = NULL, HIsStringAndBranch(HValue* value, HBasicBlock* true_target = NULL,
...@@ -4502,7 +4503,7 @@ class HIsSmiAndBranch FINAL : public HUnaryControlInstruction { ...@@ -4502,7 +4503,7 @@ class HIsSmiAndBranch FINAL : public HUnaryControlInstruction {
protected: protected:
virtual bool DataEquals(HValue* other) OVERRIDE { return true; } virtual bool DataEquals(HValue* other) OVERRIDE { return true; }
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
HIsSmiAndBranch(HValue* value, HIsSmiAndBranch(HValue* value,
...@@ -5390,7 +5391,7 @@ class HUnknownOSRValue FINAL : public HTemplateInstruction<0> { ...@@ -5390,7 +5391,7 @@ class HUnknownOSRValue FINAL : public HTemplateInstruction<0> {
public: public:
DECLARE_INSTRUCTION_FACTORY_P2(HUnknownOSRValue, HEnvironment*, int); DECLARE_INSTRUCTION_FACTORY_P2(HUnknownOSRValue, HEnvironment*, int);
virtual std::ostream& PrintDataTo(std::ostream& os) const; // NOLINT virtual std::ostream& PrintDataTo(std::ostream& os) const OVERRIDE; // NOLINT
virtual Representation RequiredInputRepresentation(int index) OVERRIDE { virtual Representation RequiredInputRepresentation(int index) OVERRIDE {
return Representation::None(); return Representation::None();
...@@ -5713,7 +5714,7 @@ class HStoreCodeEntry FINAL: public HTemplateInstruction<2> { ...@@ -5713,7 +5714,7 @@ class HStoreCodeEntry FINAL: public HTemplateInstruction<2> {
return new(zone) HStoreCodeEntry(function, code); return new(zone) HStoreCodeEntry(function, code);
} }
virtual Representation RequiredInputRepresentation(int index) { virtual Representation RequiredInputRepresentation(int index) OVERRIDE {
return Representation::Tagged(); return Representation::Tagged();
} }
...@@ -6597,11 +6598,13 @@ class HLoadKeyed FINAL ...@@ -6597,11 +6598,13 @@ class HLoadKeyed FINAL
} }
bool HasDependency() const { return OperandAt(0) != OperandAt(2); } bool HasDependency() const { return OperandAt(0) != OperandAt(2); }
uint32_t base_offset() const { return BaseOffsetField::decode(bit_field_); } uint32_t base_offset() const { return BaseOffsetField::decode(bit_field_); }
bool TryIncreaseBaseOffset(uint32_t increase_by_value); bool TryIncreaseBaseOffset(uint32_t increase_by_value) OVERRIDE;
HValue* GetKey() { return key(); } HValue* GetKey() OVERRIDE { return key(); }
void SetKey(HValue* key) { SetOperandAt(1, key); } void SetKey(HValue* key) OVERRIDE { SetOperandAt(1, key); }
bool IsDehoisted() const { return IsDehoistedField::decode(bit_field_); } bool IsDehoisted() const OVERRIDE {
void SetDehoisted(bool is_dehoisted) { return IsDehoistedField::decode(bit_field_);
}
void SetDehoisted(bool is_dehoisted) OVERRIDE {
bit_field_ = IsDehoistedField::update(bit_field_, is_dehoisted); bit_field_ = IsDehoistedField::update(bit_field_, is_dehoisted);
} }
virtual ElementsKind elements_kind() const OVERRIDE { virtual ElementsKind elements_kind() const OVERRIDE {
...@@ -7075,13 +7078,15 @@ class HStoreKeyed FINAL ...@@ -7075,13 +7078,15 @@ class HStoreKeyed FINAL
return IsFastSmiElementsKind(elements_kind_); return IsFastSmiElementsKind(elements_kind_);
} }
StoreFieldOrKeyedMode store_mode() const { return store_mode_; } StoreFieldOrKeyedMode store_mode() const { return store_mode_; }
ElementsKind elements_kind() const { return elements_kind_; } ElementsKind elements_kind() const OVERRIDE { return elements_kind_; }
uint32_t base_offset() const { return base_offset_; } uint32_t base_offset() const { return base_offset_; }
bool TryIncreaseBaseOffset(uint32_t increase_by_value); bool TryIncreaseBaseOffset(uint32_t increase_by_value) OVERRIDE;
HValue* GetKey() { return key(); } HValue* GetKey() OVERRIDE { return key(); }
void SetKey(HValue* key) { SetOperandAt(1, key); } void SetKey(HValue* key) OVERRIDE { SetOperandAt(1, key); }
bool IsDehoisted() const { return is_dehoisted_; } bool IsDehoisted() const OVERRIDE { return is_dehoisted_; }
void SetDehoisted(bool is_dehoisted) { is_dehoisted_ = is_dehoisted; } void SetDehoisted(bool is_dehoisted) OVERRIDE {
is_dehoisted_ = is_dehoisted;
}
bool IsUninitialized() { return is_uninitialized_; } bool IsUninitialized() { return is_uninitialized_; }
void SetUninitialized(bool is_uninitialized) { void SetUninitialized(bool is_uninitialized) {
is_uninitialized_ = is_uninitialized; is_uninitialized_ = is_uninitialized;
...@@ -7243,7 +7248,7 @@ class HTransitionElementsKind FINAL : public HTemplateInstruction<2> { ...@@ -7243,7 +7248,7 @@ class HTransitionElementsKind FINAL : public HTemplateInstruction<2> {
transitioned_map_ == instr->transitioned_map_; transitioned_map_ == instr->transitioned_map_;
} }
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
private: private:
HTransitionElementsKind(HValue* context, HTransitionElementsKind(HValue* context,
...@@ -7336,7 +7341,7 @@ class HStringCharCodeAt FINAL : public HTemplateInstruction<3> { ...@@ -7336,7 +7341,7 @@ class HStringCharCodeAt FINAL : public HTemplateInstruction<3> {
HValue*, HValue*,
HValue*); HValue*);
virtual Representation RequiredInputRepresentation(int index) { virtual Representation RequiredInputRepresentation(int index) OVERRIDE {
// The index is supposed to be Integer32. // The index is supposed to be Integer32.
return index == 2 return index == 2
? Representation::Integer32() ? Representation::Integer32()
...@@ -7729,7 +7734,7 @@ class HCheckMapValue FINAL : public HTemplateInstruction<2> { ...@@ -7729,7 +7734,7 @@ class HCheckMapValue FINAL : public HTemplateInstruction<2> {
DECLARE_CONCRETE_INSTRUCTION(CheckMapValue) DECLARE_CONCRETE_INSTRUCTION(CheckMapValue)
protected: protected:
virtual int RedefinedOperandIndex() { return 0; } virtual int RedefinedOperandIndex() OVERRIDE { return 0; }
virtual bool DataEquals(HValue* other) OVERRIDE { virtual bool DataEquals(HValue* other) OVERRIDE {
return true; return true;
...@@ -7862,7 +7867,7 @@ class HStoreFrameContext: public HUnaryOperation { ...@@ -7862,7 +7867,7 @@ class HStoreFrameContext: public HUnaryOperation {
HValue* context() { return OperandAt(0); } HValue* context() { return OperandAt(0); }
virtual Representation RequiredInputRepresentation(int index) { virtual Representation RequiredInputRepresentation(int index) OVERRIDE {
return Representation::Tagged(); return Representation::Tagged();
} }
...@@ -7884,11 +7889,11 @@ class HAllocateBlockContext: public HTemplateInstruction<2> { ...@@ -7884,11 +7889,11 @@ class HAllocateBlockContext: public HTemplateInstruction<2> {
HValue* function() const { return OperandAt(1); } HValue* function() const { return OperandAt(1); }
Handle<ScopeInfo> scope_info() const { return scope_info_; } Handle<ScopeInfo> scope_info() const { return scope_info_; }
virtual Representation RequiredInputRepresentation(int index) { virtual Representation RequiredInputRepresentation(int index) OVERRIDE {
return Representation::Tagged(); return Representation::Tagged();
} }
virtual std::ostream& PrintDataTo(std::ostream& os) const; // NOLINT virtual std::ostream& PrintDataTo(std::ostream& os) const OVERRIDE; // NOLINT
DECLARE_CONCRETE_INSTRUCTION(AllocateBlockContext) DECLARE_CONCRETE_INSTRUCTION(AllocateBlockContext)
......
...@@ -416,7 +416,7 @@ class LoadIC : public IC { ...@@ -416,7 +416,7 @@ class LoadIC : public IC {
virtual Handle<Code> CompileHandler(LookupIterator* lookup, virtual Handle<Code> CompileHandler(LookupIterator* lookup,
Handle<Object> unused, Handle<Object> unused,
CacheHolderFlag cache_holder); CacheHolderFlag cache_holder) OVERRIDE;
private: private:
virtual Handle<Code> pre_monomorphic_stub() const; virtual Handle<Code> pre_monomorphic_stub() const;
...@@ -545,7 +545,7 @@ class StoreIC : public IC { ...@@ -545,7 +545,7 @@ class StoreIC : public IC {
JSReceiver::StoreFromKeyed store_mode); JSReceiver::StoreFromKeyed store_mode);
virtual Handle<Code> CompileHandler(LookupIterator* lookup, virtual Handle<Code> CompileHandler(LookupIterator* lookup,
Handle<Object> value, Handle<Object> value,
CacheHolderFlag cache_holder); CacheHolderFlag cache_holder) OVERRIDE;
private: private:
inline void set_target(Code* code); inline void set_target(Code* code);
......
...@@ -59,8 +59,7 @@ class Processor: public AstVisitor { ...@@ -59,8 +59,7 @@ class Processor: public AstVisitor {
} }
// Node visitors. // Node visitors.
#define DEF_VISIT(type) \ #define DEF_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
virtual void Visit##type(type* node);
AST_NODE_LIST(DEF_VISIT) AST_NODE_LIST(DEF_VISIT)
#undef DEF_VISIT #undef DEF_VISIT
......
...@@ -100,7 +100,7 @@ class ExternalStreamingStream : public BufferedUtf16CharacterStream { ...@@ -100,7 +100,7 @@ class ExternalStreamingStream : public BufferedUtf16CharacterStream {
return 0; return 0;
} }
virtual unsigned FillBuffer(unsigned position); virtual unsigned FillBuffer(unsigned position) OVERRIDE;
private: private:
void HandleUtf8SplitCharacters(unsigned* data_in_buffer); void HandleUtf8SplitCharacters(unsigned* data_in_buffer);
......
...@@ -752,7 +752,7 @@ class StringTableInsertionKey : public HashTableKey { ...@@ -752,7 +752,7 @@ class StringTableInsertionKey : public HashTableKey {
DCHECK(string->IsInternalizedString()); DCHECK(string->IsInternalizedString());
} }
virtual bool IsMatch(Object* string) { virtual bool IsMatch(Object* string) OVERRIDE {
// We know that all entries in a hash table had their hash keys created. // We know that all entries in a hash table had their hash keys created.
// Use that knowledge to have fast failure. // Use that knowledge to have fast failure.
if (hash_ != HashForObject(string)) return false; if (hash_ != HashForObject(string)) return false;
......
...@@ -630,7 +630,7 @@ class PartialSerializer : public Serializer { ...@@ -630,7 +630,7 @@ class PartialSerializer : public Serializer {
// Serialize the objects reachable from a single object pointer. // Serialize the objects reachable from a single object pointer.
void Serialize(Object** o); void Serialize(Object** o);
virtual void SerializeObject(HeapObject* o, HowToCode how_to_code, virtual void SerializeObject(HeapObject* o, HowToCode how_to_code,
WhereToPoint where_to_point, int skip); WhereToPoint where_to_point, int skip) OVERRIDE;
private: private:
int PartialSnapshotCacheIndex(HeapObject* o); int PartialSnapshotCacheIndex(HeapObject* o);
...@@ -675,7 +675,7 @@ class StartupSerializer : public Serializer { ...@@ -675,7 +675,7 @@ class StartupSerializer : public Serializer {
// 3) Weak references (e.g. the string table). // 3) Weak references (e.g. the string table).
virtual void SerializeStrongReferences(); virtual void SerializeStrongReferences();
virtual void SerializeObject(HeapObject* o, HowToCode how_to_code, virtual void SerializeObject(HeapObject* o, HowToCode how_to_code,
WhereToPoint where_to_point, int skip); WhereToPoint where_to_point, int skip) OVERRIDE;
void SerializeWeakReferences(); void SerializeWeakReferences();
void Serialize() { void Serialize() {
SerializeStrongReferences(); SerializeStrongReferences();
...@@ -720,7 +720,7 @@ class CodeSerializer : public Serializer { ...@@ -720,7 +720,7 @@ class CodeSerializer : public Serializer {
} }
virtual void SerializeObject(HeapObject* o, HowToCode how_to_code, virtual void SerializeObject(HeapObject* o, HowToCode how_to_code,
WhereToPoint where_to_point, int skip); WhereToPoint where_to_point, int skip) OVERRIDE;
void SerializeBuiltin(int builtin_index, HowToCode how_to_code, void SerializeBuiltin(int builtin_index, HowToCode how_to_code,
WhereToPoint where_to_point); WhereToPoint where_to_point);
......
...@@ -72,10 +72,10 @@ class AstTyper: public AstVisitor { ...@@ -72,10 +72,10 @@ class AstTyper: public AstVisitor {
var->IsParameter() ? parameter_index(var->index()) : kNoVar; var->IsParameter() ? parameter_index(var->index()) : kNoVar;
} }
void VisitDeclarations(ZoneList<Declaration*>* declarations); void VisitDeclarations(ZoneList<Declaration*>* declarations) OVERRIDE;
void VisitStatements(ZoneList<Statement*>* statements); void VisitStatements(ZoneList<Statement*>* statements) OVERRIDE;
#define DECLARE_VISIT(type) virtual void Visit##type(type* node); #define DECLARE_VISIT(type) virtual void Visit##type(type* node) OVERRIDE;
AST_NODE_LIST(DECLARE_VISIT) AST_NODE_LIST(DECLARE_VISIT)
#undef DECLARE_VISIT #undef DECLARE_VISIT
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment