Commit af927dac authored by Johannes Henkel's avatar Johannes Henkel Committed by Commit Bot

[DevTools] Remove V8InspectorSession::stateJSON().

https://chromium.googlesource.com/v8/v8.git/+/refs/heads/7.6-lkgr/include/v8-inspector.h
has the V8_DEPRECATED method.

And looks like
https://chromium.googlesource.com/v8/v8.git/+/refs/heads/7.7.1
has been cut, so this is no longer needed.

Change-Id: I9db414df4900fc24cd6789708464f9d90bfb64f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649344Reviewed-by: 's avatarAlexei Filippov <alph@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62102}
parent f4d2ccc3
...@@ -130,10 +130,6 @@ class V8_EXPORT V8InspectorSession { ...@@ -130,10 +130,6 @@ class V8_EXPORT V8InspectorSession {
// Dispatching protocol messages. // Dispatching protocol messages.
static bool canDispatchMethod(const StringView& method); static bool canDispatchMethod(const StringView& method);
virtual void dispatchProtocolMessage(const StringView& message) = 0; virtual void dispatchProtocolMessage(const StringView& message) = 0;
virtual V8_DEPRECATED("Use state() instead",
std::unique_ptr<StringBuffer> stateJSON()) {
return nullptr;
}
virtual std::vector<uint8_t> state() = 0; virtual std::vector<uint8_t> state() = 0;
virtual std::vector<std::unique_ptr<protocol::Schema::API::Domain>> virtual std::vector<std::unique_ptr<protocol::Schema::API::Domain>>
supportedDomains() = 0; supportedDomains() = 0;
......
...@@ -365,14 +365,6 @@ void V8InspectorSessionImpl::dispatchProtocolMessage( ...@@ -365,14 +365,6 @@ void V8InspectorSessionImpl::dispatchProtocolMessage(
} }
} }
std::unique_ptr<StringBuffer> V8InspectorSessionImpl::stateJSON() {
std::vector<uint8_t> json;
IPEStatus status = ConvertCBORToJSON(SpanFrom(state()), &json);
DCHECK(status.ok());
USE(status);
return v8::base::make_unique<BinaryStringBuffer>(std::move(json));
}
std::vector<uint8_t> V8InspectorSessionImpl::state() { std::vector<uint8_t> V8InspectorSessionImpl::state() {
std::vector<uint8_t> out; std::vector<uint8_t> out;
m_state->writeBinary(&out); m_state->writeBinary(&out);
......
...@@ -64,7 +64,6 @@ class V8InspectorSessionImpl : public V8InspectorSession, ...@@ -64,7 +64,6 @@ class V8InspectorSessionImpl : public V8InspectorSession,
// V8InspectorSession implementation. // V8InspectorSession implementation.
void dispatchProtocolMessage(const StringView& message) override; void dispatchProtocolMessage(const StringView& message) override;
std::unique_ptr<StringBuffer> stateJSON() override;
std::vector<uint8_t> state() override; std::vector<uint8_t> state() override;
std::vector<std::unique_ptr<protocol::Schema::API::Domain>> supportedDomains() std::vector<std::unique_ptr<protocol::Schema::API::Domain>> supportedDomains()
override; override;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment