Commit aeb8f324 authored by Junliang Yan's avatar Junliang Yan Committed by Commit Bot

PPC/s390: [masm] Don't push CodeObject when entering INTERNAL frames

Port 75763183

Original Commit Message:

    The code slot of internal frames seems to be basically unused.
    As always, there are exceptions:

    1. In elements.cc we check whether the current code object is the apply
    builtin. We can use a heap lookup through the frame's pc instead.
    2. In isolate.cc we store a reference to the frame's code object to try
    and pack it into the minidump. This can safely be skipped.

    Remaining use-sites in frames.cc all skip INTERNAL frames by using the
    JavaScriptFrameIterator.

R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: I3612b206f25b9e53645d2e1bc726a5e318a1f4be
Reviewed-on: https://chromium-review.googlesource.com/1076505Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#53427}
parent 8993cff5
......@@ -1024,10 +1024,6 @@ void TurboAssembler::EnterFrame(StackFrame::Type type,
mov(ip, Operand(StackFrame::TypeToMarker(type)));
PushCommonFrame(ip);
}
if (type == StackFrame::INTERNAL) {
Move(ip, CodeObject());
push(ip);
}
}
int TurboAssembler::LeaveFrame(StackFrame::Type type, int stack_adjustment) {
......
......@@ -1043,11 +1043,6 @@ void TurboAssembler::EnterFrame(StackFrame::Type type,
Load(ip, Operand(StackFrame::TypeToMarker(type)));
PushCommonFrame(ip);
if (type == StackFrame::INTERNAL) {
Move(r1, CodeObject());
push(r1);
}
}
int TurboAssembler::LeaveFrame(StackFrame::Type type, int stack_adjustment) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment