Commit ae64bdce authored by jgruber's avatar jgruber Committed by Commit bot

[debugger] Remove unused arg from setPauseOnExceptionsImpl

BUG=v8:5530

Review-Url: https://chromiumcodereview.appspot.com/2436613002
Cr-Commit-Position: refs/heads/master@{#40425}
parent 9acec9f0
......@@ -199,12 +199,10 @@ void V8DebuggerAgentImpl::restore() {
return;
enable();
ErrorString error;
int pauseState = v8::DebugInterface::NoBreakOnException;
m_state->getInteger(DebuggerAgentState::pauseOnExceptionsState, &pauseState);
setPauseOnExceptionsImpl(&error, pauseState);
DCHECK(error.isEmpty());
setPauseOnExceptionsImpl(pauseState);
m_skipAllPauses =
m_state->booleanProperty(DebuggerAgentState::skipAllPauses, false);
......@@ -217,6 +215,7 @@ void V8DebuggerAgentImpl::restore() {
String16 blackboxPattern;
if (m_state->getString(DebuggerAgentState::blackboxPattern,
&blackboxPattern)) {
ErrorString error;
if (!setBlackboxPattern(&error, blackboxPattern)) UNREACHABLE();
}
}
......@@ -699,11 +698,10 @@ void V8DebuggerAgentImpl::setPauseOnExceptions(
*errorString = "Unknown pause on exceptions mode: " + stringPauseState;
return;
}
setPauseOnExceptionsImpl(errorString, pauseState);
setPauseOnExceptionsImpl(pauseState);
}
void V8DebuggerAgentImpl::setPauseOnExceptionsImpl(ErrorString* errorString,
int pauseState) {
void V8DebuggerAgentImpl::setPauseOnExceptionsImpl(int pauseState) {
m_debugger->setPauseOnExceptionsState(
static_cast<v8::DebugInterface::ExceptionBreakState>(pauseState));
m_state->setInteger(DebuggerAgentState::pauseOnExceptionsState, pauseState);
......
......@@ -158,7 +158,7 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
void changeJavaScriptRecursionLevel(int step);
void setPauseOnExceptionsImpl(ErrorString*, int);
void setPauseOnExceptionsImpl(int);
std::unique_ptr<protocol::Debugger::Location> resolveBreakpoint(
const String16& breakpointId, const String16& scriptId,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment