Commit add66231 authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[clang-tidy] Use explicit default and override.

See
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html
and
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html.

Also see
https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use.

Bug: v8:10488
Change-Id: Id377cab4db7ff211e800b2078ab91c3deb9a1b21
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191350Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67722}
parent 5d1392b6
...@@ -76,8 +76,8 @@ UDisplayContext ToUDisplayContext(JSDisplayNames::Style style) { ...@@ -76,8 +76,8 @@ UDisplayContext ToUDisplayContext(JSDisplayNames::Style style) {
// Abstract class for all different types. // Abstract class for all different types.
class DisplayNamesInternal { class DisplayNamesInternal {
public: public:
DisplayNamesInternal() {} DisplayNamesInternal() = default;
virtual ~DisplayNamesInternal() {} virtual ~DisplayNamesInternal() = default;
virtual const char* type() const = 0; virtual const char* type() const = 0;
virtual icu::Locale locale() const = 0; virtual icu::Locale locale() const = 0;
virtual Maybe<icu::UnicodeString> of(Isolate* isolate, virtual Maybe<icu::UnicodeString> of(Isolate* isolate,
...@@ -101,7 +101,7 @@ class LocaleDisplayNamesCommon : public DisplayNamesInternal { ...@@ -101,7 +101,7 @@ class LocaleDisplayNamesCommon : public DisplayNamesInternal {
icu::LocaleDisplayNames::createInstance(locale, display_context, 4)); icu::LocaleDisplayNames::createInstance(locale, display_context, 4));
} }
virtual ~LocaleDisplayNamesCommon() {} ~LocaleDisplayNamesCommon() override = default;
icu::Locale locale() const override { return ldn_->getLocale(); } icu::Locale locale() const override { return ldn_->getLocale(); }
...@@ -118,7 +118,7 @@ class LanguageNames : public LocaleDisplayNamesCommon { ...@@ -118,7 +118,7 @@ class LanguageNames : public LocaleDisplayNamesCommon {
LanguageNames(const icu::Locale& locale, JSDisplayNames::Style style, LanguageNames(const icu::Locale& locale, JSDisplayNames::Style style,
bool fallback) bool fallback)
: LocaleDisplayNamesCommon(locale, style, fallback) {} : LocaleDisplayNamesCommon(locale, style, fallback) {}
virtual ~LanguageNames() {} ~LanguageNames() override = default;
const char* type() const override { return "language"; } const char* type() const override { return "language"; }
Maybe<icu::UnicodeString> of(Isolate* isolate, Maybe<icu::UnicodeString> of(Isolate* isolate,
const char* code) const override { const char* code) const override {
...@@ -145,7 +145,7 @@ class RegionNames : public LocaleDisplayNamesCommon { ...@@ -145,7 +145,7 @@ class RegionNames : public LocaleDisplayNamesCommon {
RegionNames(const icu::Locale& locale, JSDisplayNames::Style style, RegionNames(const icu::Locale& locale, JSDisplayNames::Style style,
bool fallback) bool fallback)
: LocaleDisplayNamesCommon(locale, style, fallback) {} : LocaleDisplayNamesCommon(locale, style, fallback) {}
virtual ~RegionNames() {} ~RegionNames() override = default;
const char* type() const override { return "region"; } const char* type() const override { return "region"; }
Maybe<icu::UnicodeString> of(Isolate* isolate, Maybe<icu::UnicodeString> of(Isolate* isolate,
const char* code) const override { const char* code) const override {
...@@ -167,7 +167,7 @@ class ScriptNames : public LocaleDisplayNamesCommon { ...@@ -167,7 +167,7 @@ class ScriptNames : public LocaleDisplayNamesCommon {
ScriptNames(const icu::Locale& locale, JSDisplayNames::Style style, ScriptNames(const icu::Locale& locale, JSDisplayNames::Style style,
bool fallback) bool fallback)
: LocaleDisplayNamesCommon(locale, style, fallback) {} : LocaleDisplayNamesCommon(locale, style, fallback) {}
virtual ~ScriptNames() {} ~ScriptNames() override = default;
const char* type() const override { return "script"; } const char* type() const override { return "script"; }
Maybe<icu::UnicodeString> of(Isolate* isolate, Maybe<icu::UnicodeString> of(Isolate* isolate,
const char* code) const override { const char* code) const override {
...@@ -189,7 +189,7 @@ class CurrencyNames : public LocaleDisplayNamesCommon { ...@@ -189,7 +189,7 @@ class CurrencyNames : public LocaleDisplayNamesCommon {
CurrencyNames(const icu::Locale& locale, JSDisplayNames::Style style, CurrencyNames(const icu::Locale& locale, JSDisplayNames::Style style,
bool fallback) bool fallback)
: LocaleDisplayNamesCommon(locale, style, fallback) {} : LocaleDisplayNamesCommon(locale, style, fallback) {}
virtual ~CurrencyNames() {} ~CurrencyNames() override = default;
const char* type() const override { return "currency"; } const char* type() const override { return "currency"; }
Maybe<icu::UnicodeString> of(Isolate* isolate, Maybe<icu::UnicodeString> of(Isolate* isolate,
const char* code) const override { const char* code) const override {
...@@ -267,7 +267,7 @@ class DateTimeFieldNames : public DisplayNamesInternal { ...@@ -267,7 +267,7 @@ class DateTimeFieldNames : public DisplayNamesInternal {
icu::DateTimePatternGenerator::createInstance(locale_, status)); icu::DateTimePatternGenerator::createInstance(locale_, status));
CHECK(U_SUCCESS(status)); CHECK(U_SUCCESS(status));
} }
virtual ~DateTimeFieldNames() {} ~DateTimeFieldNames() override = default;
const char* type() const override { return "dateTimeField"; } const char* type() const override { return "dateTimeField"; }
icu::Locale locale() const override { return locale_; } icu::Locale locale() const override { return locale_; }
Maybe<icu::UnicodeString> of(Isolate* isolate, Maybe<icu::UnicodeString> of(Isolate* isolate,
...@@ -314,7 +314,7 @@ class DateFormatSymbolsNames : public DisplayNamesInternal { ...@@ -314,7 +314,7 @@ class DateFormatSymbolsNames : public DisplayNamesInternal {
length_(length), length_(length),
calendar_(calendar) {} calendar_(calendar) {}
virtual ~DateFormatSymbolsNames() {} ~DateFormatSymbolsNames() override = default;
const char* type() const override { return type_; } const char* type() const override { return type_; }
...@@ -354,7 +354,7 @@ class WeekdayNames : public DateFormatSymbolsNames { ...@@ -354,7 +354,7 @@ class WeekdayNames : public DateFormatSymbolsNames {
const icu::UnicodeString* array, int32_t length, const icu::UnicodeString* array, int32_t length,
const char* calendar) const char* calendar)
: DateFormatSymbolsNames(type, locale, array, length, calendar) {} : DateFormatSymbolsNames(type, locale, array, length, calendar) {}
virtual ~WeekdayNames() {} ~WeekdayNames() override = default;
int32_t ComputeIndex(const char* code) const override { int32_t ComputeIndex(const char* code) const override {
int32_t i = atoi(code); int32_t i = atoi(code);
...@@ -370,7 +370,7 @@ class MonthNames : public DateFormatSymbolsNames { ...@@ -370,7 +370,7 @@ class MonthNames : public DateFormatSymbolsNames {
const icu::UnicodeString* array, int32_t length, const icu::UnicodeString* array, int32_t length,
const char* calendar) const char* calendar)
: DateFormatSymbolsNames(type, locale, array, length, calendar) {} : DateFormatSymbolsNames(type, locale, array, length, calendar) {}
virtual ~MonthNames() {} ~MonthNames() override = default;
int32_t ComputeIndex(const char* code) const override { int32_t ComputeIndex(const char* code) const override {
return atoi(code) - 1; return atoi(code) - 1;
...@@ -383,7 +383,7 @@ class QuarterNames : public DateFormatSymbolsNames { ...@@ -383,7 +383,7 @@ class QuarterNames : public DateFormatSymbolsNames {
const icu::UnicodeString* array, int32_t length, const icu::UnicodeString* array, int32_t length,
const char* calendar) const char* calendar)
: DateFormatSymbolsNames(type, locale, array, length, calendar) {} : DateFormatSymbolsNames(type, locale, array, length, calendar) {}
virtual ~QuarterNames() {} ~QuarterNames() override = default;
int32_t ComputeIndex(const char* code) const override { int32_t ComputeIndex(const char* code) const override {
return atoi(code) - 1; return atoi(code) - 1;
...@@ -396,7 +396,7 @@ class DayPeriodNames : public DateFormatSymbolsNames { ...@@ -396,7 +396,7 @@ class DayPeriodNames : public DateFormatSymbolsNames {
const icu::UnicodeString* array, int32_t length, const icu::UnicodeString* array, int32_t length,
const char* calendar) const char* calendar)
: DateFormatSymbolsNames(type, locale, array, length, calendar) {} : DateFormatSymbolsNames(type, locale, array, length, calendar) {}
virtual ~DayPeriodNames() {} ~DayPeriodNames() override = default;
int32_t ComputeIndex(const char* code) const override { int32_t ComputeIndex(const char* code) const override {
if (strcmp("am", code) == 0) { if (strcmp("am", code) == 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment