[test] Migrate cctest/test-local-handles to unittests/

Bug: v8:12781
Change-Id: I759024fb18ee596ecb678e5b70c95235ea91e520
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3827126Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82464}

test/cctest/BUILD.gn

@@ -191,7 +191,6 @@ v8_source_set("cctest_sources") {
     "test-inspector.cc",
     "test-js-weak-refs.cc",
     "test-liveedit.cc",
-    "test-local-handles.cc",
     "test-lockers.cc",
     "test-mementos.cc",
     "test-orderedhashtable.cc",

test/cctest/cctest.status

@@ -100,9 +100,6 @@
   'test-code-stub-assembler/PopAndReturnFromJSBuiltinWithStackParameters' : [FAIL],
   'test-code-stub-assembler/PopAndReturnFromTFCBuiltinWithStackParameters' : [FAIL],
 
-  # These tests are supposed to fail in a slow DCHECK, skip them otherwise.
-  'test-local-handles/DereferenceLocalHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
-
   # Slow tests.
   'test-api/InternalFieldsSubclassing': [PASS, SLOW],
   'test-debug/CallFunctionInDebugger': [PASS, ['mode == debug', SLOW]],

test/unittests/BUILD.gn

@@ -380,6 +380,7 @@ v8_source_set("unittests_sources") {
     "heap/lab-unittest.cc",
     "heap/list-unittest.cc",
     "heap/local-factory-unittest.cc",
+    "heap/local-handles-unittest.cc",
     "heap/local-heap-unittest.cc",
     "heap/marking-inner-pointer-resolution-unittest.cc",
     "heap/marking-unittest.cc",

test/cctest/test-local-handles.cc → test/unittests/heap/local-handles-unittest.cc

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "src/handles/local-handles.h"
+
 #include <memory>
 
 #include "src/api/api.h"
@@ -10,16 +12,17 @@
 #include "src/common/globals.h"
 #include "src/handles/handles-inl.h"
 #include "src/handles/local-handles-inl.h"
-#include "src/handles/local-handles.h"
 #include "src/heap/heap.h"
 #include "src/heap/local-heap.h"
 #include "src/heap/parked-scope.h"
 #include "src/objects/heap-number.h"
-#include "test/cctest/cctest.h"
+#include "test/unittests/test-utils.h"
 
 namespace v8 {
 namespace internal {
 
+using LocalHandlesTest = TestWithIsolate;
+
 namespace {
 
 class LocalHandlesThread final : public v8::base::Thread {
@@ -67,9 +70,8 @@ class LocalHandlesThread final : public v8::base::Thread {
   base::Semaphore* sema_gc_finished_;
 };
 
-TEST(CreateLocalHandles) {
-  CcTest::InitializeVM();
-  Isolate* isolate = CcTest::i_isolate();
+TEST_F(LocalHandlesTest, CreateLocalHandles) {
+  Isolate* isolate = i_isolate();
 
   Address object = kNullAddress;
 
@@ -88,23 +90,21 @@ TEST(CreateLocalHandles) {
 
   sema_started.Wait();
 
-  CcTest::CollectAllGarbage();
+  CollectAllGarbage();
   sema_gc_finished.Signal();
 
   thread->Join();
 }
 
-TEST(CreateLocalHandlesWithoutLocalHandleScope) {
-  CcTest::InitializeVM();
-  Isolate* isolate = CcTest::i_isolate();
+TEST_F(LocalHandlesTest, CreateLocalHandlesWithoutLocalHandleScope) {
+  Isolate* isolate = i_isolate();
   HandleScope handle_scope(isolate);
 
   handle(Smi::FromInt(17), isolate->main_thread_local_heap());
 }
 
-TEST(DereferenceLocalHandle) {
-  CcTest::InitializeVM();
-  Isolate* isolate = CcTest::i_isolate();
+TEST_F(LocalHandlesTest, DereferenceLocalHandle) {
+  Isolate* isolate = i_isolate();
 
   // Create a PersistentHandle to create the LocalHandle, and thus not have a
   // HandleScope present to override the LocalHandleScope.
@@ -125,9 +125,8 @@ TEST(DereferenceLocalHandle) {
   }
 }
 
-TEST(DereferenceLocalHandleFailsWhenDisallowed) {
-  CcTest::InitializeVM();
-  Isolate* isolate = CcTest::i_isolate();
+TEST_F(LocalHandlesTest, DereferenceLocalHandleFailsWhenDisallowed) {
+  Isolate* isolate = i_isolate();
 
   // Create a PersistentHandle to create the LocalHandle, and thus not have a
   // HandleScope present to override the LocalHandleScope.

test/unittests/unittests.status

@@ -15,6 +15,7 @@
   'PlatformTest.StackAlignment': [PASS, ['not is_clang', SKIP]],
 
   # These tests are supposed to fail in a slow DCHECK, skip them otherwise.
+  'LocalHandlesTest.DereferenceLocalHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
   'PersistentHandlesTest.DereferencePersistentHandleFailsWhenDisallowed': [SKIP, ['mode == debug', FAIL]],
 
   'IntlTest.StringLocaleCompareFastPath': [['mode != release', SKIP], SLOW, NO_VARIANTS],