Skip to content

V
V8
Commit ad711b06 authored by Milad Fa's avatar Milad Fa Committed by V8 LUCI CQ
Browse files
Options

PPC: Fix build with no web assembly 

Fixing build with `v8_enable_webassembly = false`.

Change-Id: Ib69e3f462f6fe9122707d1b3260262bbb83f5399
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3708474
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
Cr-Commit-Position: refs/heads/main@{#81207}
parent 035ba1d8
Show whitespace changes
Inline Side-by-side
Showing with 55 additions and 55 deletions
src/compiler/backend/ppc/code-generator-ppc.cc
View file @ ad711b06
...@@ -574,6 +574,7 @@ Condition FlagsConditionToCondition(FlagsCondition condition, ArchOpcode op) { ...@@ -574,6 +574,7 @@ Condition FlagsConditionToCondition(FlagsCondition condition, ArchOpcode op) {
#define CleanUInt32(x) #define CleanUInt32(x)
#endif #endif
#if V8_ENABLE_WEBASSEMBLY
static inline bool is_wasm_on_be(bool IsWasm) { static inline bool is_wasm_on_be(bool IsWasm) {
#if V8_TARGET_BIG_ENDIAN #if V8_TARGET_BIG_ENDIAN
return IsWasm; return IsWasm;
...@@ -581,21 +582,26 @@ static inline bool is_wasm_on_be(bool IsWasm) { ...@@ -581,21 +582,26 @@ static inline bool is_wasm_on_be(bool IsWasm) {
return false; return false;
#endif #endif
} }
#endif
#define MAYBE_REVERSE_IF_WASM(dst, src, op, reset) \ #if V8_ENABLE_WEBASSEMBLY
#define MAYBE_REVERSE_IF_WASM(dst, src, op, scratch, reset) \
if (is_wasm_on_be(info()->IsWasm())) { \ if (is_wasm_on_be(info()->IsWasm())) { \
__ op(dst, src, kScratchReg); \ __ op(dst, src, scratch); \
if (reset) src = dst; \ if (reset) src = dst; \
} }
#else
#define MAYBE_REVERSE_IF_WASM(dst, src, op, scratch, reset)
#endif
#define ASSEMBLE_ATOMIC_EXCHANGE(_type, reverse_op) \ #define ASSEMBLE_ATOMIC_EXCHANGE(_type, reverse_op) \
do { \ do { \
Register val = i.InputRegister(2); \ Register val = i.InputRegister(2); \
Register dst = i.OutputRegister(); \ Register dst = i.OutputRegister(); \
MAYBE_REVERSE_IF_WASM(ip, val, reverse_op, true); \ MAYBE_REVERSE_IF_WASM(ip, val, reverse_op, kScratchReg, true); \
__ AtomicExchange<_type>( \ __ AtomicExchange<_type>( \
MemOperand(i.InputRegister(0), i.InputRegister(1)), val, dst); \ MemOperand(i.InputRegister(0), i.InputRegister(1)), val, dst); \
MAYBE_REVERSE_IF_WASM(dst, dst, reverse_op, false); \ MAYBE_REVERSE_IF_WASM(dst, dst, reverse_op, kScratchReg, false); \
} while (false) } while (false)
#define ASSEMBLE_ATOMIC_COMPARE_EXCHANGE(_type, reverse_op) \ #define ASSEMBLE_ATOMIC_COMPARE_EXCHANGE(_type, reverse_op) \
...@@ -603,12 +609,12 @@ static inline bool is_wasm_on_be(bool IsWasm) { ...@@ -603,12 +609,12 @@ static inline bool is_wasm_on_be(bool IsWasm) {
Register expected_val = i.InputRegister(2); \ Register expected_val = i.InputRegister(2); \
Register new_val = i.InputRegister(3); \ Register new_val = i.InputRegister(3); \
Register dst = i.OutputRegister(); \ Register dst = i.OutputRegister(); \
MAYBE_REVERSE_IF_WASM(ip, expected_val, reverse_op, true); \ MAYBE_REVERSE_IF_WASM(ip, expected_val, reverse_op, kScratchReg, true); \
MAYBE_REVERSE_IF_WASM(r0, new_val, reverse_op, true); \ MAYBE_REVERSE_IF_WASM(r0, new_val, reverse_op, kScratchReg, true); \
__ AtomicCompareExchange<_type>( \ __ AtomicCompareExchange<_type>( \
MemOperand(i.InputRegister(0), i.InputRegister(1)), expected_val, \ MemOperand(i.InputRegister(0), i.InputRegister(1)), expected_val, \
new_val, dst, kScratchReg); \ new_val, dst, kScratchReg); \
MAYBE_REVERSE_IF_WASM(dst, dst, reverse_op, false); \ MAYBE_REVERSE_IF_WASM(dst, dst, reverse_op, kScratchReg, false); \
} while (false) } while (false)
#define ASSEMBLE_ATOMIC_BINOP_BYTE(bin_inst, _type) \ #define ASSEMBLE_ATOMIC_BINOP_BYTE(bin_inst, _type) \
...@@ -632,10 +638,7 @@ static inline bool is_wasm_on_be(bool IsWasm) { ...@@ -632,10 +638,7 @@ static inline bool is_wasm_on_be(bool IsWasm) {
do { \ do { \
auto bin_op = [&](Register dst, Register lhs, Register rhs) { \ auto bin_op = [&](Register dst, Register lhs, Register rhs) { \
Register _lhs = lhs; \ Register _lhs = lhs; \
if (is_wasm_on_be(info()->IsWasm())) { \ MAYBE_REVERSE_IF_WASM(dst, _lhs, reverse_op, scratch, true); \
__ reverse_op(dst, lhs, scratch); \
_lhs = dst; \
} \
if (std::is_signed<_type>::value) { \ if (std::is_signed<_type>::value) { \
switch (sizeof(_type)) { \ switch (sizeof(_type)) { \
case 1: \ case 1: \
...@@ -654,17 +657,14 @@ static inline bool is_wasm_on_be(bool IsWasm) { ...@@ -654,17 +657,14 @@ static inline bool is_wasm_on_be(bool IsWasm) {
} \ } \
} \ } \
__ bin_inst(dst, _lhs, rhs); \ __ bin_inst(dst, _lhs, rhs); \
if (is_wasm_on_be(info()->IsWasm())) { \ MAYBE_REVERSE_IF_WASM(dst, dst, reverse_op, scratch, false); \
__ reverse_op(dst, dst, scratch); \
} \
}; \ }; \
MemOperand dst_operand = \ MemOperand dst_operand = \
MemOperand(i.InputRegister(0), i.InputRegister(1)); \ MemOperand(i.InputRegister(0), i.InputRegister(1)); \
__ AtomicOps<_type>(dst_operand, i.InputRegister(2), i.OutputRegister(), \ __ AtomicOps<_type>(dst_operand, i.InputRegister(2), i.OutputRegister(), \
kScratchReg, bin_op); \ kScratchReg, bin_op); \
if (is_wasm_on_be(info()->IsWasm())) { \ MAYBE_REVERSE_IF_WASM(i.OutputRegister(), i.OutputRegister(), reverse_op, \
__ reverse_op(i.OutputRegister(), i.OutputRegister(), scratch); \ scratch, false); \
} \
break; \ break; \
} while (false) } while (false)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment