Commit acd2a7f1 authored by Takuto Ikuta's avatar Takuto Ikuta Committed by Commit Bot

small fix for BUILD.gn

Header generating action needs to be in public_deps if generated header is included from header file in the targets depending on the action target.

See below reference for more details.
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps

Bug: chromium:931596
Change-Id: I198d9e09b8585b213ec4b375f10aecc6268f3bdd
Reviewed-on: https://chromium-review.googlesource.com/c/1469545Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59579}
parent d6b1f5bc
...@@ -1321,6 +1321,9 @@ v8_source_set("v8_initializers") { ...@@ -1321,6 +1321,9 @@ v8_source_set("v8_initializers") {
deps = [ deps = [
":torque_generated_initializers", ":torque_generated_initializers",
]
public_deps = [
":v8_base", ":v8_base",
] ]
...@@ -2970,8 +2973,6 @@ v8_source_set("v8_base") { ...@@ -2970,8 +2973,6 @@ v8_source_set("v8_base") {
defines = [] defines = []
deps = [ deps = [
":generate_bytecode_builtins_list",
":run_torque",
":v8_headers", ":v8_headers",
":v8_libbase", ":v8_libbase",
":v8_libsampler", ":v8_libsampler",
...@@ -2979,10 +2980,13 @@ v8_source_set("v8_base") { ...@@ -2979,10 +2980,13 @@ v8_source_set("v8_base") {
"src/inspector:inspector", "src/inspector:inspector",
] ]
public_deps = [
":generate_bytecode_builtins_list",
":run_torque",
]
if (v8_enable_i18n_support) { if (v8_enable_i18n_support) {
public_deps = [ public_deps += [ "//third_party/icu" ]
"//third_party/icu",
]
if (is_win) { if (is_win) {
deps += [ "//third_party/icu:icudata" ] deps += [ "//third_party/icu:icudata" ]
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment